8384085: Make os::Bsd::dlopen_helper private, and drop unused arg#31069
8384085: Make os::Bsd::dlopen_helper private, and drop unused arg#31069snake66 wants to merge 2 commits intoopenjdk:masterfrom
Conversation
The os::Bsd::dlopen_helper function is only used by the locally by the class itself, so there's no reason to expose it publicly. Also, the mode arg is unused, and can be removed. This work was sponsored by: The FreeBSD Foundation Co-authored-by: Greg Lewis <glewis@eyesbeyond.net>
|
👋 Welcome back haraldei! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
Webrevs
|
Arraying
left a comment
Arraying
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! I've left a small suggestion for you to consider. Could you also please bump the Oracle copyright update year to 2026?
| static void set_numa_interleave_memory(numa_interleave_memory_func_t func) { _numa_interleave_memory = func; } | ||
| static void set_numa_all_nodes(unsigned long* ptr) { _numa_all_nodes = ptr; } | ||
|
|
||
| static void *dlopen_helper(const char *path, char *ebuf, int ebuflen); |
There was a problem hiding this comment.
FWIW, if dlopen_helper is only ever called from dll_load's definition, there's plenty of precedent for it to just be a static function in the .cpp and not explicitly be listed as a class method.
There was a problem hiding this comment.
That's probably even better. Thanks I'll update the patch.
This work is sponsored by The FreeBSD Foundation
2 participants
The os::Bsd::dlopen_helper function is only used by the locally by the class itself, so there's no reason to expose it publicly. Also, the mode arg is unused, and can be removed.
This work was sponsored by: The FreeBSD Foundation
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31069/head:pull/31069$ git checkout pull/31069Update a local copy of the PR:
$ git checkout pull/31069$ git pull https://git.openjdk.org/jdk.git pull/31069/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31069View PR using the GUI difftool:
$ git pr show -t 31069Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31069.diff
Using Webrev
Link to Webrev Comment