8383769: compiler/c2/TestDependsOnTestSqrtHFAssertion.java timed out

[anton-seoane]

This PR limits the execution of a occasionally timing out test to the platform context in which it only makes sense to run it.

The regression test for JDK-8378897 has been found occasionally to be timing out (most recently in the Valhalla CI). This test only makes sense in the context of AVX512-FP16-enabled x86 CPUs, and should therefore only be executed when such features are available.

Testing: test is now skipped if the CPU does not support AVX512-FP16

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8383769: compiler/c2/TestDependsOnTestSqrtHFAssertion.java timed out (Bug - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Quan Anh Mai (@merykitty - Reviewer)
• Jatin Bhateja (@jatin-bhateja - Reviewer) Review applies to c2e3bb4b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31072/head:pull/31072
$ git checkout pull/31072

Update a local copy of the PR:
$ git checkout pull/31072
$ git pull https://git.openjdk.org/jdk.git pull/31072/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31072

View PR using the GUI difftool:
$ git pr show -t 31072

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31072.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aseoane! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@anton-seoane This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8383769: compiler/c2/TestDependsOnTestSqrtHFAssertion.java timed out

Reviewed-by: kvn, qamai, jbhateja

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

• 0b0a5a7: 8381843: FileDialog:setFile() specification needs to be enhanced w.r.to file selection
• 84afc28: 8384089: Correctly catch invalid uses of StubCodeMark
• 18d0d27: 8382035: [ubsan] Under UBSAN builds, disable tests that rely on simulated JVM crashes
• ... and 68 more: https://git.openjdk.org/jdk/compare/3b50c4809deef109c4d5dfab04e81d01d8f1a5ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov, @merykitty, @jatin-bhateja) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@anton-seoane The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

[anton-seoane]

Pinging @jatin-bhateja, as he was the one who originally introduced the test

[mlbridge]

Webrevs

• 01: Full - Incremental (23a8c89d)
• 00: Full (c2e3bb4b)

[vnkozlov]

Good.

[merykitty]

Looks good to me. This test runs the main loop for 100_000 iterations, maybe this can be lowered, too?

[anton-seoane]

@merykitty yes, originally I thought of bounding ctr too, as I'm not sure it adds much to the test. Would bumping down the count to e.g. 10_000 and bounding ctr to 0..99 be okay with you?

[jatin-bhateja]

Pinging @jatin-bhateja, as he was the one who originally introduced the test

Change looks good to me.

[merykitty]

@anton-seoane I think that is fine, currently, the inner loop runs for 5 billion iterations, which is unnecessarily large. If you lower that number, I think you can even skip the @require change.

[anton-seoane]

I've now reduced the number of iterations, and added -Xbatch to make sure the compilation is actually done. The test runs quite faster now, so no need to reduce coverage via @requires.

[merykitty]

Looks good to me, thanks for making the changes.

[vnkozlov]

Does it reproduce original failure with reduced iterations and -Xbatch?

[anton-seoane]

@vnkozlov although it looks like a yes, unfortunately we don't have the resources (i.e. avx512fp16-enabled machines) to check that. Maybe @jatin-bhateja could clear that for us?

[vnkozlov]

Okay