8384097: G1: G1ConcurrentMarkThread::total_mark_cpu_time_s adds together nanoseconds and seconds

[tschatzl]

Hi all,

please review this fix for a time unit mismatch when calculating "marking" time.

This only affects some log message.

Testing: gha

Thanks,
Thomas

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8384097: G1: G1ConcurrentMarkThread::total_mark_cpu_time_s adds together nanoseconds and seconds (Bug - P4)

Reviewers

• Ivan Walulya (@walulyai - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31074/head:pull/31074
$ git checkout pull/31074

Update a local copy of the PR:
$ git checkout pull/31074
$ git pull https://git.openjdk.org/jdk.git pull/31074/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31074

View PR using the GUI difftool:
$ git pr show -t 31074

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31074.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8384097: G1: G1ConcurrentMarkThread::total_mark_cpu_time_s adds together nanoseconds and seconds

Reviewed-by: iwalulya, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• c833dc0: 8379396: "assert(offset + partition_size <= size()) failed: partition failed" when combining NonProfiledCodeHeapSize and large value for CICompilerCount
• a6d763a: 8383172: Create AbstractLRUReferencePolicy base class

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-gc. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (92fb8f26)

[shipilev]

Looks okay.