8384100: UNSIGNED5::Reader::try_skip() is missing a terminating condition

[mgronlun]

Greetings,

Tiny fix for try_skip().

Found when fixing JDK-8382332

Thanks
Markus

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8384100: UNSIGNED5::Reader::try_skip() is missing a terminating condition (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31077/head:pull/31077
$ git checkout pull/31077

Update a local copy of the PR:
$ git checkout pull/31077
$ git pull https://git.openjdk.org/jdk.git pull/31077/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31077

View PR using the GUI difftool:
$ git pr show -t 31077

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31077.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@mgronlun The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

[mgronlun]

/reviewers 1

[openjdk]

@mgronlun
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

[mlbridge]

Webrevs

• 00: Full (460bf9d6)

[mgronlun]

Curiously, the existing call site in FieldInfo skip has not trapped on the assert.

Perhaps a compiler inlining this location will remove the return value 's' and, subsequently, also remove the assert? Will try to see what the compiler produces here, in debug builds.

[mgronlun]

Curiously, the existing call site in FieldInfo skip has not trapped on the assert.

Perhaps a compiler inlining this location will remove the return value 's' and, subsequently, also remove the assert? Will try to see what the compiler produces here, in debug builds.

Not so mysterious after all: FieldInfoReader::skip_field_info() and FieldInfoReader::skip_to_field_info() don't have any usages.