8384095: [ppc64] assert(is_MachTemp() || res->isa_ptr() == nullptr) failed: must not be a pointer#31078
Conversation
…ailed: must not be a pointer
|
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@TheRealMDoerr The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
The bottom_type is computed differently since JDK-8379667. Now,
MachNode::bottom_type()uses_opnds[0]->type()which is incorrect for TOC related nodes which useiRegPdstOper()for non-oop values. Note that postalloc expand nodes only exist for PPC64.I can still see GC issues. May be a separate issue.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31078/head:pull/31078$ git checkout pull/31078Update a local copy of the PR:
$ git checkout pull/31078$ git pull https://git.openjdk.org/jdk.git pull/31078/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31078View PR using the GUI difftool:
$ git pr show -t 31078Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31078.diff
Using Webrev
Link to Webrev Comment