Skip to content

8384095: [ppc64] assert(is_MachTemp() || res->isa_ptr() == nullptr) failed: must not be a pointer#31078

Draft
TheRealMDoerr wants to merge 3 commits intoopenjdk:masterfrom
TheRealMDoerr:8384095_PPC64_postalloc_expand_bottom_type
Draft

8384095: [ppc64] assert(is_MachTemp() || res->isa_ptr() == nullptr) failed: must not be a pointer#31078
TheRealMDoerr wants to merge 3 commits intoopenjdk:masterfrom
TheRealMDoerr:8384095_PPC64_postalloc_expand_bottom_type

Conversation

@TheRealMDoerr
Copy link
Copy Markdown
Contributor

@TheRealMDoerr TheRealMDoerr commented May 7, 2026

The bottom_type is computed differently since JDK-8379667. Now, MachNode::bottom_type() uses _opnds[0]->type() which is incorrect for TOC related nodes which use iRegPdstOper() for non-oop values. Note that postalloc expand nodes only exist for PPC64.

I can still see GC issues. May be a separate issue.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8384095: [ppc64] assert(is_MachTemp() || res->isa_ptr() == nullptr) failed: must not be a pointer (Bug - P1)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31078/head:pull/31078
$ git checkout pull/31078

Update a local copy of the PR:
$ git checkout pull/31078
$ git pull https://git.openjdk.org/jdk.git pull/31078/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31078

View PR using the GUI difftool:
$ git pr show -t 31078

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31078.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 7, 2026

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label May 7, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-compiler. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 7, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 7, 2026

Webrevs

@TheRealMDoerr TheRealMDoerr marked this pull request as draft May 7, 2026 21:01
@openjdk openjdk Bot removed the rfr Pull request is ready for review label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

1 participant