Skip to content

8384104: Obsolete Xmaxjitcodesize#31079

Open
anton-seoane wants to merge 2 commits intoopenjdk:masterfrom
anton-seoane:JDK-8384104
Open

8384104: Obsolete Xmaxjitcodesize#31079
anton-seoane wants to merge 2 commits intoopenjdk:masterfrom
anton-seoane:JDK-8384104

Conversation

@anton-seoane
Copy link
Copy Markdown
Contributor

@anton-seoane anton-seoane commented May 7, 2026 •
edited by openjdk Bot
Loading

This PR obsoletes the Xmaxjitcodesize flag in JDK 27. Please see the deprecation CSR for workarounds for users interested in keeping similar behaviour.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8384104: Obsolete Xmaxjitcodesize (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/31079/head:pull/31079
$ git checkout pull/31079

Update a local copy of the PR:
$ git checkout pull/31079
$ git pull https://git.openjdk.org/jdk.git pull/31079/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31079

View PR using the GUI difftool:
$ git pr show -t 31079

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/31079.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented May 7, 2026

👋 Welcome back aseoane! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title JDK-8384104 8384104: Obsolete Xmaxjitcodesize May 7, 2026
@openjdk openjdk Bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 7, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026 •
edited
Loading

@anton-seoane The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@anton-seoane anton-seoane marked this pull request as ready for review May 7, 2026 18:05
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 7, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented May 7, 2026 •
edited
Loading

Webrevs

@anton-seoane
Copy link
Copy Markdown
Contributor Author

anton-seoane commented May 7, 2026

/label remove hotspot-runtime
/label add hotspot-compiler

@openjdk openjdk Bot removed the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 7, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

@anton-seoane
The hotspot-runtime label was successfully removed.

@openjdk openjdk Bot added hotspot-compiler hotspot-compiler-dev@openjdk.org and removed rfr Pull request is ready for review labels May 7, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented May 7, 2026

@anton-seoane
The hotspot-compiler label was successfully added.

@openjdk openjdk Bot added the rfr Pull request is ready for review label May 7, 2026
vnkozlov
vnkozlov reviewed May 7, 2026
View reviewed changes
Comment thread src/hotspot/share/runtime/arguments.cpp Outdated
warning("Option -Xmaxjitcodesize was deprecated in JDK 26 and will likely be removed in a future release.");
}
} else if (match_option(option, "-Xmaxjitcodesize", &tail)) {
warning("Ignoring option -Xmaxjitcodesize; support was removed in JDK 27");
Copy link
Copy Markdown
Contributor

@vnkozlov vnkozlov May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places use next to get VM version:

      char version[256];
      JDK_Version::jdk(17).to_string(version, sizeof(version));

Copy link
Copy Markdown
Contributor Author

@anton-seoane anton-seoane May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it to do it this way, too... hopefully it just lasts for a version as it should be completely removed in 28 😄

vnkozlov
vnkozlov approved these changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vnkozlov vnkozlov vnkozlov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org rfr Pull request is ready for review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anton-seoane @vnkozlov