Add FGAC integration tests for multi-index PPL queries#5581
Draft
finnegancarroll wants to merge 1 commit into
Draft
Add FGAC integration tests for multi-index PPL queries#5581finnegancarroll wants to merge 1 commit into
finnegancarroll wants to merge 1 commit into
Conversation
finnegancarroll
force-pushed
the
analytics-engine-security-it-wildcards
branch
13 times, most recently
from
b6fc89f to
9de2f9d
Compare
Regression tests for authorization bypass where PPL multi-index queries (source = idx1, idx2) only evaluated permissions on the first index, allowing unauthorized access to subsequent indices. Tests cover: - Authorized index first, unauthorized second (the bypass vector) - Backtick-quoted variant of the same - Unauthorized index first (control: should be denied) - Both indices authorized (positive case) Signed-off-by: Finnegan Carroll <carrofin@amazon.com> Signed-off-by: Finn Carroll <carrofin@amazon.com>
finnegancarroll
force-pushed
the
analytics-engine-security-it-wildcards
branch
from
9de2f9d to
38a327d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds regression tests verifying that FGAC correctly evaluates permissions on all indices in comma-separated multi-source PPL queries. Previously, only the first index in the list was checked, allowing unauthorized access to subsequent indices.
Test cases
testPPLMultiIndexDeniedWhenSecondIndexUnauthorizedsource = allowed, forbidden→ must be 403testPPLMultiIndexDeniedWithBackticksAuthorizedFirsttestPPLMultiIndexDeniedWithUnauthorizedFirstsource = forbidden, allowed→ 403 (control)testPPLMultiIndexAllowedWhenAllAuthorizedsource = allowed1, allowed2→ succeedsAlso fixes
Plugin install order in
analyticsEngineSecurityITcluster config —composite-enginemust be installed beforeanalytics-backend-lucene(dependency).Validation
All 4 tests pass on latest upstream main — confirms the bypass is not present on current HEAD.
Signed-off-by: Finnegan Carroll carrofin@amazon.com