Skip to content

HYPERFLEET-1246: Make kind required on ObjectReference, remove ObjectReference2 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 23, 2026
+25 −16
Merged

HYPERFLEET-1246: Make kind required on ObjectReference, remove ObjectReference2 #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.0.23] - 2026-06-22

### Changed

- `kind` field on `ObjectReference` is now required (was optional but API validates as mandatory)

### Removed

- Unused `ObjectReference2<Kind>` generic model

## [1.0.22] - 2026-06-18

### Fixed
Expand Down Expand Up @@ -206,7 +216,8 @@ First official stable release of the HyperFleet API specification.
- Interactive API documentation

<!-- Links -->
[Unreleased]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec/compare/v1.0.22...HEAD
[Unreleased]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec/compare/v1.0.23...HEAD
[1.0.23]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec/compare/v1.0.22...v1.0.23
[1.0.22]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec/compare/v1.0.21...v1.0.22
[1.0.21]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec/compare/v1.0.20...v1.0.21
[1.0.20]: https://github.com/openshift-hyperfleet/hyperfleet-api-spec/compare/v1.0.18...v1.0.20
Expand Down
2 changes: 1 addition & 1 deletion main.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ using OpenAPI;
*/
@service(#{ title: "HyperFleet API" })
@info(#{
version: "1.0.22",
version: "1.0.23",

@coderabbitai coderabbitai Bot Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Version extraction failure blocks release validation.

CI is failing to parse @info.version from main.tsp after this change, which blocks the validation job. Keep the version: "x.y.z" token parser-compatible at Line [33] or update the CI extractor in the same PR.

As per coding guidelines, "**: Prioritize Critical and Major severity issues."

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@main.tsp` at line 33, The version string format at line 33 in main.tsp is no
longer compatible with the CI's version extraction logic for the `@info.version`
field, causing the release validation to fail. Either revert the version token
back to the format that the CI parser expects (check previous version formats in
git history), or update the CI version extractor configuration in the same pull
request to handle the new format. Ensure the fix is made in this PR before
merging to unblock the validation job.

Sources: Coding guidelines, Pipeline failures

contact: #{
name: "HyperFleet Team",
url: "https://github.com/openshift-hyperfleet",
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "hyperfleet",
"version": "1.0.22",
"version": "1.0.23",
Comment thread
kuudori marked this conversation as resolved.
"type": "module",
"exports": {
"./*": "./*"
Expand Down
9 changes: 8 additions & 1 deletion schemas/core/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
openapi: 3.0.0
info:
title: HyperFleet API
version: 1.0.22
version: 1.0.23
contact:
name: HyperFleet Team
url: https://github.com/openshift-hyperfleet
Expand Down Expand Up @@ -1766,6 +1766,7 @@ components:
Cluster:
type: object
required:
- kind
- name
- spec
- created_time
Expand Down Expand Up @@ -1879,6 +1880,7 @@ components:
ClusterCreateRequest:
type: object
required:
- kind
- name
- spec
properties:
Expand Down Expand Up @@ -2043,6 +2045,7 @@ components:
NodePool:
type: object
required:
- kind
- name
- spec
- created_time
Expand Down Expand Up @@ -2163,6 +2166,7 @@ components:
NodePoolCreateRequest:
type: object
required:
- kind
- name
- spec
properties:
Expand Down Expand Up @@ -2198,6 +2202,7 @@ components:
NodePoolCreateResponse:
type: object
required:
- kind
- name
- spec
- created_time
Expand Down Expand Up @@ -2342,6 +2347,8 @@ components:
trace_id: deadbeef12345678
ObjectReference:
type: object
required:
- kind
properties:
id:
type: string
Expand Down
11 changes: 1 addition & 10 deletions shared/models/common/model.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,11 @@ model ObjectReference {
...ID;

/** Resource kind */
kind?: string;
kind: string;

/** Resource URI */
href?: string;
}
model ObjectReference2<Kind> {
...ID;

/** Resource kind */
kind: Kind;

/** Resource URI */
href: string;
}

/**
* Field-level validation error detail
Expand Down