OCPCLOUD-3507: Add OTE e2e tests for ClusterAPIMachineManagement feature gate by pmeida · Pull Request #606 · openshift/cluster-capi-operator

pmeida · 2026-06-23T09:50:30Z

Summary

Adds 10 non-disruptive health-check e2e tests registered with the OTE binary that validate the Cluster API stack is correctly installed and operational when the ClusterAPIMachineManagement feature gate is enabled. These tests provide the Sippy signal required for feature gate promotion.

Tests

All tests are blocking, capio/parallel → openshift/conformance/parallel:

Context	Test
Operator & controller deployments	capi-operator deployment available
Operator & controller deployments	cluster-api ClusterOperator reporting healthy
Operator & controller deployments	capi-controllers deployment available
Operator & controller deployments	capi-installer deployment available
Provider images & initialization	capi-installer-images ConfigMap present
CRD & API readiness	core Cluster API CRDs installed and established
CRD & API readiness	platform-specific infrastructure CRDs installed
Management cluster resources	management Cluster object present with InfrastructureReady=True
Management cluster resources	platform-specific infrastructure cluster object present
Management cluster resources	management cluster kubeconfig Secret present

Design notes

InfrastructureReady check uses WaitLong (15 min) since infra reconciliation can be slow on degraded clusters
Validated against a real AWS TechPreview cluster — all 10 tests pass both via bin/cluster-capi-operator-tests-ext run-suite capio/parallel and via make e2e

Dependencies

Requires OCPCLOUD-3010: Enable OTE for Cluster CAPI Operator origin#31307 to be merged for OTE nightlies to discover and invoke the binary
Can be merged independently; nightlies pick up tests once both PRs land

openshift-merge-bot · 2026-06-23T09:50:32Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-06-23T09:50:34Z

@pmeida: This pull request references OCPCLOUD-3507 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Adds 10 non-disruptive health-check e2e tests registered with the OTE binary that validate the Cluster API stack is correctly installed and operational when the ClusterAPIMachineManagement feature gate is enabled. These tests provide the Sippy signal required for feature gate promotion per OCPSTRAT-2660.

Follows the same pattern as #599 (CRD Compatibility Checker tests).

Tests

All tests are blocking, capio/parallel → openshift/conformance/parallel:

Context Test

Operator & controller deployments capi-operator deployment available

Operator & controller deployments cluster-api ClusterOperator reporting healthy

Operator & controller deployments capi-controllers deployment available

Operator & controller deployments capi-installer deployment available

Provider images & initialization capi-installer-images ConfigMap present

CRD & API readiness core Cluster API CRDs installed and established

CRD & API readiness platform-specific infrastructure CRDs installed

Management cluster resources management Cluster object present with InfrastructureReady=True

Management cluster resources platform-specific infrastructure cluster object present

Management cluster resources management cluster kubeconfig Secret present

Design notes

Platform-specific tests derive the infrastructure Kind from Cluster.Spec.InfrastructureRef.GroupKind() — no hardcoded platform map, works for any platform CAPI supports without code changes

API version is resolved dynamically via the REST mapper to avoid version pinning across provider upgrades

InfrastructureReady check uses WaitLong (15 min) since infra reconciliation can be slow on degraded clusters

Validated against a real AWS TechPreview cluster — all 10 tests pass

Dependencies

Requires OCPCLOUD-3010: Enable OTE for Cluster CAPI Operator origin#31307 to be merged for OTE nightlies to discover and invoke the binary

Can be merged independently; nightlies pick up tests once both PRs land

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-23T09:50:50Z

Warning

Review limit reached

@pmeida, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 31 minutes and 35 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dd0edaf2-8d4f-4b02-8b79-47fbd0a6bb10

📥 Commits

Reviewing files that changed from the base of the PR and between 5656e20 and 41da49e.

📒 Files selected for processing (2)

e2e/cluster_api_machine_management.go
e2e/framework/framework.go

Walkthrough

A new e2e Ginkgo ordered test suite is added in e2e/cluster_api_machine_management.go. It is gated on features.FeatureGateClusterAPIMachineManagement and validates deployment availability, ClusterOperator health conditions, installer-images ConfigMap presence, core and platform-specific CRD establishment, management Cluster infrastructure readiness, and kubeconfig Secret existence.

Changes

Cluster API Machine Management E2E Suite

Layer / File(s)	Summary
Feature-gated E2E validation suite `e2e/cluster_api_machine_management.go`	Adds an ordered Ginkgo suite gated on `ClusterAPIMachineManagement` that checks `DeploymentAvailable=True` for `capi-operator`, `capi-controllers`, and `capi-installer`; asserts ClusterOperator `Available=True`, `Degraded=False`, `Progressing=False`; verifies the `capi-installer-images` ConfigMap is non-empty; validates `Established=True` for core CRDs (`clusters`, `machines`, `machinesets`) and the platform-specific infrastructure CRD resolved via REST mapping from `InfrastructureRef`; confirms the management `Cluster` object has `InfrastructureReady=True`; fetches the platform-specific infrastructure cluster CR by GVK and name; and asserts the `<clusterName>-kubeconfig` Secret contains a `value` key.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

nrb
racheljpg

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-06-23T09:51:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pmeida · 2026-06-23T09:53:18Z

/ok-to-test

…ure gate Add 10 non-disruptive health-check tests registered with the OTE binary that validate the Cluster API stack is correctly installed and operational when the ClusterAPIMachineManagement feature gate is enabled. Tests provide the Sippy signal required for feature gate promotion. Tests (all blocking, capio/parallel): - capi-operator deployment available in openshift-cluster-api-operator - cluster-api ClusterOperator reporting Available, not Degraded, not Progressing - capi-controllers deployment available in openshift-cluster-api - capi-installer deployment available in openshift-cluster-api-operator - capi-installer-images ConfigMap present in openshift-cluster-api-operator - Core CAPI CRDs (clusters, machines, machinesets) installed and established - Platform-specific infrastructure CRDs installed (derived from Cluster.Spec.InfrastructureRef) - Management Cluster object present with InfrastructureReady=True - Platform-specific infrastructure cluster object present (AWSCluster etc.) - Management cluster kubeconfig Secret present Platform-specific tests derive the infra Kind from the live Cluster object's InfrastructureRef rather than a hardcoded platform map, so no code changes are needed when new platforms are added. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

openshift-ci · 2026-06-23T10:28:24Z

@pmeida: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pmeida · 2026-06-23T10:40:30Z

To confirm if e2e tests go trough
/test e2e-aws-capi-techpreview

openshift-ci · 2026-06-23T10:46:47Z

@pmeida: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2026-06-23T10:46:50Z

@pmeida: This PR was included in a payload test run from #606
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2026-06-23T10:47:51Z

@pmeida: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

pmeida · 2026-06-23T10:51:29Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview-serial openshift/origin#31307

openshift-ci · 2026-06-23T10:51:50Z

@pmeida: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7d80c200-6ef1-11f1-8a6b-01a933de5987-0

pmeida · 2026-06-23T15:12:39Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview openshift/origin#31307

openshift-ci · 2026-06-23T15:12:46Z

@pmeida: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f9d50680-6f15-11f1-876b-e0aef72228f3-0

pmeida · 2026-06-23T15:20:22Z

/payload-job-with-prs periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview openshift/origin#31307

openshift-ci · 2026-06-23T15:20:44Z

@pmeida: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-ovn-single-node-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0da6c440-6f17-11f1-88d3-1d650fa5fcee-0

pmeida · 2026-06-23T15:32:51Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview openshift/origin#31307

openshift-ci · 2026-06-23T15:32:58Z

@pmeida: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ccc72ee0-6f18-11f1-8b1e-eefb4a048f63-0

pmeida · 2026-06-23T15:49:23Z

@pmeida: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ccc72ee0-6f18-11f1-8b1e-eefb4a048f63-0

OTE run validation. Has to be done like this until we get the origin PR merged. Afterwards, we can also see OTE tests run through the e2e-aws-ovn-techpreview presubmit for this specific example

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 23, 2026

openshift-ci Bot requested review from RadekManak and racheljpg June 23, 2026 09:51

openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 23, 2026

pmeida force-pushed the OCPCLOUD-3507 branch from f75013f to 41da49e Compare June 23, 2026 10:18

openshift-ci Bot mentioned this pull request Jun 23, 2026

OCPCLOUD-3010: Enable OTE for Cluster CAPI Operator openshift/origin#31307

Open

2 tasks

Conversation

pmeida commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Design notes

Dependencies

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Design notes

Dependencies

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

pmeida commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

pmeida commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

pmeida commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

pmeida commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

pmeida commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

pmeida commented Jun 23, 2026

Uh oh!

openshift-ci Bot commented Jun 23, 2026

Uh oh!

pmeida commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pmeida commented Jun 23, 2026 •

edited

Loading

openshift-ci-robot commented Jun 23, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading