Skip to content

Enable watch termination grace period (redux). #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
benluddy wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Draft

Enable watch termination grace period (redux). #2200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bindata/assets/config/defaultconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ apiServerArguments:
- 70s # give SDN some time to converge: 30s for iptable lock contention, 25s for the second try and some seconds for AWS to update ELBs
shutdown-send-retry-after:
- "true"
shutdown-watch-termination-grace-period:
- 5s # shorter than the pod graceful termination period on single-node

@sdodson sdodson Jun 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being higher extends the overall termination period? I guess if we find that 5s is insufficient here we can explore something like the controller that adjusts goaway-chance based on SNO vs HA.

storage-backend:
- etcd3
storage-media-type:
Expand Down