Skip to content

OCPNODE-4520: Update enhancement for 5.0 GA target#2022

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
saschagrunert:ocpnode-4520-update-enhancement-5.0-ga
Jun 3, 2026
Merged

OCPNODE-4520: Update enhancement for 5.0 GA target#2022
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
saschagrunert:ocpnode-4520-update-enhancement-5.0-ga

Conversation

@saschagrunert

@saschagrunert saschagrunert commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Update the additional storage configuration enhancement to reflect
the current implementation state and 5.0 GA target.

  • Update status from provisional to implementable
  • Align API types with shipped API (StorePath type, correct struct hierarchy)
  • Document MCO :ref suffix auto-append behavior
  • Check off completed TP and GA prerequisite items (feature gate, API review, MCO, CRI-O v1.36, docs, test coverage, security review, RHOAI, field feedback, migration path)
  • Pin GA target to 5.0, add upgrade/downgrade paths
  • Strengthen experimental API risk documentation
  • Add implementation references and related JIRA issues

cc @haircommander @QiWang19 @sairameshv @harche @bitoku @yuqi-zhang

API PR: openshift/api#2858

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2026
@openshift-ci-robot

openshift-ci-robot commented May 26, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown

@saschagrunert: This pull request references OCPNODE-4520 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Update the additional storage configuration enhancement to reflect
the current implementation state and 5.0 GA target.

  • Update status from provisional to implementable
  • Add 5.0 GA goal (promote AdditionalStorageConfig to Default)
  • Update API types to match shipped API (shared StorePath type,
    consecutive slash validation)
  • Document MCO :ref suffix auto-append behavior
  • Check off completed TP checklist items (feature gate, API review,
    MCO implementation, CRI-O v1.36)
  • Pin GA target from 4.23+ to 5.0
  • Add GA upgrade path (4.22 to 5.0)
  • Strengthen experimental API risk documentation

cc @haircommander @QiWang19 @sairameshv @harche @bitoku @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from mandre and patrickdillon May 26, 2026 08:05
@saschagrunert saschagrunert force-pushed the ocpnode-4520-update-enhancement-5.0-ga branch 4 times, most recently from 2b48a50 to 800605b Compare May 26, 2026 08:37
@saschagrunert
OCPNODE-4520: Update enhancement for 5.0 GA target
81f7d3f 
- Update status from provisional to implementable
- Add 5.0 GA goal (promote AdditionalStorageConfig to Default)
- Update API types to match shipped API (StorePath type,
  consecutive slash validation, correct struct hierarchy)
- Document MCO :ref suffix auto-append behavior
- Check off completed TP and GA prerequisite items
- Mark CRI-O v1.36 risk as resolved
- Pin GA target from 4.23+ to 5.0
- Add GA upgrade/downgrade paths (4.22 to 5.0)
- Strengthen experimental API risk documentation
- Fix OCPNODE-4051 description to match JIRA title
- Add references for shipped implementation PRs and GA stories
- Fix field count (three, not two)

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert force-pushed the ocpnode-4520-update-enhancement-5.0-ga branch from 800605b to 81f7d3f Compare May 26, 2026 08:39
@saschagrunert saschagrunert mentioned this pull request May 26, 2026
Open
@haircommander

haircommander commented May 26, 2026

Copy link
Copy Markdown
Member

LGTM

@saschagrunert

saschagrunert commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

PTAL @QiWang19 @sairameshv @harche @bitoku @yuqi-zhang

QiWang19
QiWang19 reviewed Jun 1, 2026
View reviewed changes

@QiWang19 QiWang19 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2026
@saschagrunert

saschagrunert commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

Friendly ping for /approve: @mrunalp @mandre @patrickdillon @yuqi-zhang

bitoku
bitoku reviewed Jun 2, 2026
View reviewed changes
Comment thread enhancements/machine-config/additional-storage-config-crio.md
yuqi-zhang
yuqi-zhang approved these changes Jun 3, 2026
View reviewed changes

@yuqi-zhang yuqi-zhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and links. A read-through of the updates makes sense to me (most of it has merged already, so I don't think there's too much to discuss here)

/hold

In case you feel that you want another person to take a look, but feel free to remove the hold if you're happy merging as is.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2026
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@saschagrunert

saschagrunert commented Jun 3, 2026

Copy link
Copy Markdown
Member Author

/unhold

Thank you!

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2026
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@saschagrunert: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 83fc71e into openshift:master Jun 3, 2026
2 checks passed
@saschagrunert saschagrunert deleted the ocpnode-4520-update-enhancement-5.0-ga branch June 3, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre Awaiting requested review from mandre

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

3 more reviewers

@bitoku bitoku bitoku left review comments

@QiWang19 QiWang19 QiWang19 left review comments

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@QiWang19 QiWang19

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@saschagrunert @openshift-ci-robot @haircommander @bitoku @yuqi-zhang @QiWang19