Skip to content

Fix unexpected request event emission#2688

Open
jacobsee wants to merge 1 commit into
openshift:release-4.22from
jacobsee:test-unexpected-request-event-emission
Open

Fix unexpected request event emission#2688
jacobsee wants to merge 1 commit into
openshift:release-4.22from
jacobsee:test-unexpected-request-event-emission

Conversation

@jacobsee

@jacobsee jacobsee commented Jun 9, 2026

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

This event needs to be of the named type eventfFunc rather than an anonymous type with the same signature, else when its type is checked later, it does not get properly consumed.

Which issue(s) this PR is related to:

Backport related to OCPBUGS-86789.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 9, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5337f8e5-d77f-4951-a79f-2a855e8faf81

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot

Copy link
Copy Markdown

@jacobsee: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci Bot added the vendor-update Touching vendor dir or related files label Jun 9, 2026
@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobsee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2026
@jacobsee

jacobsee commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

/payload-aggregate nightly-4.22-e2e-aws-ovn-single-node 10

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

@jacobsee: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@jacobsee

jacobsee commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node 10

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2b750ac0-642e-11f1-89fe-e2571208d9b3-0

@jacobsee

jacobsee commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node 10

@openshift-ci

openshift-ci Bot commented Jun 9, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/47848bf0-6456-11f1-9741-c6f4b985fd79-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10

@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d5c12b60-6494-11f1-9e58-3685f649c614-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10

@openshift-ci

openshift-ci Bot commented Jun 10, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/29ee0010-64f3-11f1-868e-373a2013ee82-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/66201ad0-6621-11f1-9c6a-c63ab702b99b-0

@jacobsee jacobsee force-pushed the test-unexpected-request-event-emission branch from 7794529 to b4a19c4 Compare June 12, 2026 23:46
@openshift-ci-robot

Copy link
Copy Markdown

@jacobsee: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jacobsee jacobsee changed the title do-not-merge - checking for a problem on 4.22 Fix unexpected request event emission Jun 12, 2026
@jacobsee jacobsee marked this pull request as ready for review June 12, 2026 23:50
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2026
@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/991c7d00-66b9-11f1-85c4-57a3f300a76d-0

@openshift-ci openshift-ci Bot requested review from bertinatto and jubittajohn June 12, 2026 23:52
@openshift-ci

openshift-ci Bot commented Jun 13, 2026

Copy link
Copy Markdown

@jacobsee: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial-2of3 10

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial-2of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cbb0b020-6915-11f1-8b8c-561cb92802d0-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-techpreview-serial-2of2 10

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d58db660-6915-11f1-9e83-fb1d2499c7a5-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview-serial-2of2 10

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dfbe33d0-6915-11f1-8125-bca85bce90a4-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3 10

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b8847220-6a7d-11f1-810f-5e319484ab7c-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-54.22-e2e-azure-ovn-techpreview-serial-2of2 10

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

@jacobsee: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2 10

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d13d7c80-6a7d-11f1-98ee-44d15cb29f01-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ded34500-6a7d-11f1-9752-688c9306cecd-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial-2of2 10

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/eed9bf60-6a7d-11f1-93c2-908dd33b0dc5-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 20

@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cb100ff0-6aad-11f1-85b8-ece8ae144319-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2 20

@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d85ac5b0-6aad-11f1-84e2-8f0fdd3a1e5e-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 20

@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f079b980-6ada-11f1-86be-3a57fead8d21-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2 20

@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f98df180-6ada-11f1-824a-9e54c7b0cbf7-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 20

@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/128fa360-6b38-11f1-86d9-5953b64c7b32-0

@jacobsee

Copy link
Copy Markdown
Member Author

/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2 20

@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19d8df60-6b38-11f1-8fbe-cb820d64b652-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants