Fix unexpected request event emission#2688
Conversation
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@jacobsee: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobsee The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/payload-aggregate nightly-4.22-e2e-aws-ovn-single-node 10 |
|
@jacobsee: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2b750ac0-642e-11f1-89fe-e2571208d9b3-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-single-node 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/47848bf0-6456-11f1-9741-c6f4b985fd79-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d5c12b60-6494-11f1-9e58-3685f649c614-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/29ee0010-64f3-11f1-868e-373a2013ee82-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/66201ad0-6621-11f1-9c6a-c63ab702b99b-0 |
7794529 to
b4a19c4
Compare
|
@jacobsee: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/991c7d00-66b9-11f1-85c4-57a3f300a76d-0 |
|
@jacobsee: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-aws-ovn-techpreview-serial-2of3 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cbb0b020-6915-11f1-8b8c-561cb92802d0-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-azure-ovn-techpreview-serial-2of2 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d58db660-6915-11f1-9e83-fb1d2499c7a5-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview-serial-2of2 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dfbe33d0-6915-11f1-8125-bca85bce90a4-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b8847220-6a7d-11f1-810f-5e319484ab7c-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-54.22-e2e-azure-ovn-techpreview-serial-2of2 10 |
|
@jacobsee: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d13d7c80-6a7d-11f1-98ee-44d15cb29f01-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ded34500-6a7d-11f1-9752-688c9306cecd-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-techpreview-serial-2of2 10 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/eed9bf60-6a7d-11f1-93c2-908dd33b0dc5-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 20 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cb100ff0-6aad-11f1-85b8-ece8ae144319-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2 20 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d85ac5b0-6aad-11f1-84e2-8f0fdd3a1e5e-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 20 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f079b980-6ada-11f1-86be-3a57fead8d21-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2 20 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f98df180-6ada-11f1-824a-9e54c7b0cbf7-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 20 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/128fa360-6b38-11f1-86d9-5953b64c7b32-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-techpreview-serial-2of2 20 |
|
@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19d8df60-6b38-11f1-8fbe-cb820d64b652-0 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This event needs to be of the named type
eventfFuncrather than an anonymous type with the same signature, else when its type is checked later, it does not get properly consumed.Which issue(s) this PR is related to:
Backport related to OCPBUGS-86789.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: