Skip to content

[release-4.17] OCPBUGS-82713, OCPBUGS-82692: Address CVE-2026-35469#2690

Open
atewari-rh wants to merge 1 commit into
openshift:release-4.17from
atewari-rh:CVE-2026-35469_4.17
Open

[release-4.17] OCPBUGS-82713, OCPBUGS-82692: Address CVE-2026-35469#2690
atewari-rh wants to merge 1 commit into
openshift:release-4.17from
atewari-rh:CVE-2026-35469_4.17

Conversation

@atewari-rh

Copy link
Copy Markdown

Summary

Bump github.com/moby/spdystream from v0.2.0 to v0.5.1 on release-4.17 to address CVE-2026-35469 (SPDY frame parsing DoS).

Item Link
Upstream fix kubernetes/kubernetes#138358
Advisory GHSA-pc3f-x583-g7j2
Related (4.19) openshift/kubernetes#2680
Jira OCPBUGS-82761

Problem

github.com/moby/spdystream ≤ v0.5.0 does not validate attacker-controlled counts/lengths in SPDY/3 control frames before allocation. A remote peer that can send SPDY frames can trigger memory exhaustion (OOM) via crafted SETTINGS/header frames.

Kubernetes uses spdystream via k8s.io/apimachinery/pkg/util/httpstream/spdy for kubelet streaming (exec/attach/portforward) and kube-apiserver→kubelet SPDY proxy paths.

On release-4.17, the dependency was pinned at v0.2.0.

Solution

Vendor bump to v0.5.1, which adds bounds checks on SETTINGS entry count, header count, and header field sizes.

hack/pin-dependency.sh github.com/moby/spdystream v0.5.1
hack/update-vendor.sh

Signed-off-by: atewari <atewari@redhat.com>
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 15, 2026
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a12c6555-12c1-41e7-bf1f-44357d803a1a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@atewari-rh: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot

Copy link
Copy Markdown

@atewari-rh: This pull request references Jira Issue OCPBUGS-82713, which is invalid:

  • expected dependent Jira Issue OCPBUGS-82761 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-82692, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-82737 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Bump github.com/moby/spdystream from v0.2.0 to v0.5.1 on release-4.17 to address CVE-2026-35469 (SPDY frame parsing DoS).

Item Link
Upstream fix kubernetes/kubernetes#138358
Advisory GHSA-pc3f-x583-g7j2
Related (4.19) openshift/kubernetes#2680
Jira OCPBUGS-82761

Problem

github.com/moby/spdystream ≤ v0.5.0 does not validate attacker-controlled counts/lengths in SPDY/3 control frames before allocation. A remote peer that can send SPDY frames can trigger memory exhaustion (OOM) via crafted SETTINGS/header frames.

Kubernetes uses spdystream via k8s.io/apimachinery/pkg/util/httpstream/spdy for kubelet streaming (exec/attach/portforward) and kube-apiserver→kubelet SPDY proxy paths.

On release-4.17, the dependency was pinned at v0.2.0.

Solution

Vendor bump to v0.5.1, which adds bounds checks on SETTINGS entry count, header count, and header field sizes.

hack/pin-dependency.sh github.com/moby/spdystream v0.5.1
hack/update-vendor.sh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from bertinatto and deads2k June 15, 2026 08:10
@openshift-ci openshift-ci Bot added vendor-update Touching vendor dir or related files needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 15, 2026
@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atewari-rh
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 15, 2026

Copy link
Copy Markdown

Hi @atewari-rh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atewari-rh atewari-rh changed the title [release-4.18] OCPBUGS-82713, OCPBUGS-82692: Address CVE-2026-35469 [release-4.17] OCPBUGS-82713, OCPBUGS-82692: Address CVE-2026-35469 Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants