OCPBUGS-85427: Remove trailing newline (\n) characters in klog message strings

[eric200428]

• What I did
  I removed the trailing newlines from the Klog messages.

• How to Verify
  Build a cluster and view the log messages for and extra newlines

• Description for the change log
  Removed the "\n" from the end of klog messages. Fixes OCPBUGS-85427: Remove trailing newline (\n) characters in klog message strings

Summary by CodeRabbit

• Chores
  • Standardized log message formatting across multiple system components by removing trailing newlines and extra whitespace from informational and warning logs.
  • Improves consistency and readability of logs without changing behavior or user-facing functionality.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@eric200428: This pull request references Jira Issue OCPBUGS-85427, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

• What I did
  I removed the trailing newlines from the Klog messages.

• How to Verify
  Build a cluster and view the log messages for and extra newlines

• Description for the change log
  Removed the "\n" from the end of klog messages. Fixes OCPBUGS-85427: Remove trailing newline (\n) characters in klog message strings

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7371b352-0563-40b0-8ada-e39d0fd65bbe

📥 Commits

Reviewing files that changed from the base of the PR and between 004c552 and 5529b6d.

📒 Files selected for processing (7)

• cmd/machine-config-daemon/firstboot_complete_machineconfig.go
• pkg/controller/certrotation/certrotation_controller.go
• pkg/controller/certrotation/helpers.go
• pkg/daemon/coreos.go
• pkg/daemon/daemon.go
• pkg/daemon/pivot/utils/run.go
• pkg/daemon/update.go

✅ Files skipped from review due to trivial changes (5)

• pkg/controller/certrotation/certrotation_controller.go
• pkg/daemon/pivot/utils/run.go
• pkg/daemon/coreos.go
• pkg/daemon/update.go
• pkg/controller/certrotation/helpers.go

🚧 Files skipped from review as they are similar to previous changes (2)

• cmd/machine-config-daemon/firstboot_complete_machineconfig.go
• pkg/daemon/daemon.go

---

Walkthrough

This PR removes trailing newline or trailing-space escapes from nine klog format strings across daemon and controller code; only the formatting of emitted log messages was changed, with no functional or control-flow modifications.

Changes

Log Formatting Standardization

Layer / File(s)	Summary
Firstboot retry warning formatting cmd/machine-config-daemon/firstboot_complete_machineconfig.go	Warning log in the firstboot retry loop no longer includes an explicit trailing \n in the format string.
Cert rotation info logs pkg/controller/certrotation/certrotation_controller.go	Two Info-level messages in reconcileSecret had trailing newline/whitespace removed from their klog format strings.
Daemon and helpers logging tweaks pkg/controller/certrotation/helpers.go, pkg/daemon/coreos.go, pkg/daemon/daemon.go, pkg/daemon/pivot/utils/run.go, pkg/daemon/update.go	Removed trailing \n (or trailing whitespace) from klog format strings for ignition detection, provisioning timestamp, journalctl/systemctl output prefixes, runImpl "Running:" log, and absent-user deconfiguration log.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 11

❌ Failed checks (1 warning, 10 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Stable And Deterministic Test Names	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Weak-Crypto	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title directly and accurately describes the main change: removing trailing newline characters from klog message strings across multiple files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[eric200428]

/retest-required

[umohnani8]

/jira refresh
/approved

[openshift-ci-robot]

@umohnani8: This pull request references Jira Issue OCPBUGS-85427, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh
/approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[umohnani8]

/test unit
/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

[eric200428]

/cherry-pick release-4.22

[openshift-cherrypick-robot]

@eric200428: once the present PR merges, I will cherry-pick it on top of release-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[eric200428]

/test e2e-gcp-op-ocl-part1

[umohnani8]

Test failures unrelated and being fixed in openshift/release#79990
/override ci/prow/e2e-gcp-op-ocl-part2
/override ci/prow/e2e-gcp-op-ocl-part1

[openshift-ci]

@umohnani8: Overrode contexts on behalf of umohnani8: ci/prow/e2e-gcp-op-ocl-part1, ci/prow/e2e-gcp-op-ocl-part2

Details

In response to this:

Test failures unrelated and being fixed in openshift/release#79990
/override ci/prow/e2e-gcp-op-ocl-part2
/override ci/prow/e2e-gcp-op-ocl-part1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[umohnani8]

/verified by CI

[openshift-ci-robot]

@umohnani8: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@eric200428: This pull request references Jira Issue OCPBUGS-85427, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

• What I did
  I removed the trailing newlines from the Klog messages.

• How to Verify
  Build a cluster and view the log messages for and extra newlines

• Description for the change log
  Removed the "\n" from the end of klog messages. Fixes OCPBUGS-85427: Remove trailing newline (\n) characters in klog message strings

Summary by CodeRabbit

• Chores
• Standardized log message formatting across multiple system components by removing trailing newlines and extra whitespace from informational and warning logs.
• Improves consistency and readability of logs without changing behavior or user-facing functionality.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[umohnani8]

/lgtm
/verified by CI

[openshift-ci-robot]

@umohnani8: This PR has been marked as verified by CI.

Details

In response to this:

/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eric200428, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[umohnani8]

/test e2e-aws-ovn

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 29cbc3e and 2 for PR HEAD 5529b6d in total

[eric200428]

/retest-required

[eric200428]

/test unit

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 544f390 and 1 for PR HEAD 5529b6d in total

[openshift-ci]

@eric200428: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@eric200428: Jira Issue Verification Checks: Jira Issue OCPBUGS-85427
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-85427 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

• What I did
  I removed the trailing newlines from the Klog messages.

• How to Verify
  Build a cluster and view the log messages for and extra newlines

• Description for the change log
  Removed the "\n" from the end of klog messages. Fixes OCPBUGS-85427: Remove trailing newline (\n) characters in klog message strings

Summary by CodeRabbit

• Chores
• Standardized log message formatting across multiple system components by removing trailing newlines and extra whitespace from informational and warning logs.
• Improves consistency and readability of logs without changing behavior or user-facing functionality.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@eric200428: new pull request created: #6147

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.