OCPBUGS-86889: use new skopeo location and follow redirects#6118
OCPBUGS-86889: use new skopeo location and follow redirects#6118cheesesashimi wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@cheesesashimi: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe installation script's logic for fetching the latest skopeo release is updated by changing the GitHub API endpoint from ChangesSkopeo installation source update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
hack/install-skopeo.sh (1)
44-44:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Git clone URL still points to old repository location.
Line 35 was updated to use the new repository location
podman-container-tools/skopeofor fetching the latest release tag, but this line still clones from the old locationcontainers/skopeo. This inconsistency will likely cause the installation to fail if the repository has truly moved, or may result in cloning from an outdated/unmaintained location.🐛 Proposed fix
- git clone --branch "$skopeo_version" --depth 1 https://github.com/containers/skopeo.git "$skopeo_clone_dir" + git clone --branch "$skopeo_version" --depth 1 https://github.com/podman-container-tools/skopeo.git "$skopeo_clone_dir"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@hack/install-skopeo.sh` at line 44, The git clone command that uses skopeo_version to checkout a branch still points to the old repository "containers/skopeo"; update that command to clone from the new repo "podman-container-tools/skopeo" (keep the existing --branch "$skopeo_version" --depth 1 and destination "$skopeo_clone_dir"), so the clone URL matches the earlier lookup of the latest tag and avoids fetching the wrong repository.
🧹 Nitpick comments (1)
hack/install-skopeo.sh (1)
3-3: ⚡ Quick winConsider adding
pipefailto the set options.The script uses
set -xeuobut is missing thepipefailoption. Adding it would ensure that errors in command pipelines (like line 35 where curl output is piped to python3) are properly caught and cause the script to exit.🛡️ Proposed fix
-set -xeuo +set -xeuo pipefail🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@hack/install-skopeo.sh` at line 3, The script's set options currently read "set -xeuo" which omits pipefail, so pipeline errors (e.g., the curl | python3 pipeline) won't cause the script to fail; update the options used in that set invocation (the line containing set -xeuo) to include pipefail (e.g., use set -euo pipefail or set -xeuo pipefail / set -o pipefail) so any command in a pipeline failing will trigger script exit.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@hack/install-skopeo.sh`:
- Line 44: The git clone command that uses skopeo_version to checkout a branch
still points to the old repository "containers/skopeo"; update that command to
clone from the new repo "podman-container-tools/skopeo" (keep the existing
--branch "$skopeo_version" --depth 1 and destination "$skopeo_clone_dir"), so
the clone URL matches the earlier lookup of the latest tag and avoids fetching
the wrong repository.
---
Nitpick comments:
In `@hack/install-skopeo.sh`:
- Line 3: The script's set options currently read "set -xeuo" which omits
pipefail, so pipeline errors (e.g., the curl | python3 pipeline) won't cause the
script to fail; update the options used in that set invocation (the line
containing set -xeuo) to include pipefail (e.g., use set -euo pipefail or set
-xeuo pipefail / set -o pipefail) so any command in a pipeline failing will
trigger script exit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 79ec600e-4e29-44e5-9f98-a7b5f8cbe465
📒 Files selected for processing (1)
hack/install-skopeo.sh
cheesesashimi
changed the title
openshift-ci-robot
added
the
jira/invalid-bug
|
@cheesesashimi: This pull request references Jira Issue OCPBUGS-86889, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-gcp-op-ocl-part1 |
|
@cheesesashimi: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
- What I did
Skopeo recently changed locations from https://github.com/containers/skopeo to https://github.com/podman-container-tools/skopeo. The
hack/install-skopeo.shscript was not following redirects, causing it to break. This script has been updated to use the new location along with modifying the curl call to follow redirects.- How to verify it
This change primarily impacts the OpenShift e2e-gcp-op-ocl-part1 and e2e-gcp-op-ocl-part2 jobs. So running those should verify that the change is successful.
- Description for the changelog
Use new Skopeo location for OCL E2E tests
Summary by CodeRabbit