Add inputs for cincinnati-operator Dockerfile builder stage#80357
Add inputs for cincinnati-operator Dockerfile builder stage#80357deepsm007 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Cincinnati Operator CI config adds an ChangesCincinnati Operator builder image configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai[bot]: your |
Wire Dockerfile registry.ci builder FROM to pipeline:root from build_root so pulls use quay-proxy after ART QCI migration.
|
@openshift-ci[bot]: your |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-cincinnati-operator-master-images |
|
@deepsm007: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@openshift-merge-bot[bot]: your |
|
@openshift-ci[bot]: your |
|
@deepsm007: |
|
@openshift-merge-bot[bot]: your |
|
@deepsm007: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@openshift-ci[bot]: your |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, deepsm007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-ci[bot]: your |
|
/hold |
|
/close in favor of openshift/ci-tools#5244 |
https://redhat-internal.slack.com/archives/CBN38N3MW/p1781013922005829
After ART migrated builder imagestreams to push directly to QCI instead of registry.ci.openshift.org (art-tools#3025), the cincinnati-operator Dockerfile still pulls registry.ci.openshift.org/ocp/builder directly and fails with manifest unknown.
Add inputs mapping that FROM to pipeline:root (already imported from quay-proxy via build_root) so the image build no longer depends on the removed registry.ci tag.
/cc @openshift/test-platform
Summary by CodeRabbit
This PR updates the OpenShift CI configuration for the openshift/cincinnati-operator repository to fix a broken image build. The cincinnati-operator's image build (build/Dockerfile) referenced the now-removed registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.22-openshift-4.18 tag and failed with "manifest unknown". The change adds an inputs mapping for the image build's root input so the Dockerfile's FROM that previously pointed at the registry.ci builder tag is provided from the pipeline image (pipeline:root), which is already imported via the existing build_root configuration. As a result, the image build will pull from quay-proxy/pipeline:root instead of the deleted registry.ci tag, avoiding manifest errors without modifying the repository's Dockerfile or source code.