HYPERFLEET-1108 - feat: Pass E2E_RUN_ID when running make install-hyp…

[mliptak0]

Summary

This PR updates the HyperFleet E2E CI setup step to pass E2E_RUN_ID when deploying HyperFleet infrastructure, enabling proper resource labeling and tracking for E2E test runs.

What changed:

• Modified openshift-hyperfleet-e2e-setup-commands.sh to pass E2E_RUN_ID=${NAMESPACE_NAME} when running make install-hyperfleet
• The E2E_RUN_ID is set to the namespace name, which is unique per CI job run

Why this is needed:

• Prerequisite for HYPERFLEET-1108: The hyperfleet-infra repository will require E2E_RUN_ID to be set when deploying to e2e-gcp environment
• Enables automatic labeling of all E2E resources with e2e.hyperfleet.io/run-id: <namespace-name>
• Allows better tracking and cleanup of resources created during E2E test runs
• Prevents resource conflicts when multiple E2E jobs run concurrently on the same shared cluster

Impact on CI:

• This change is required for HyperFleet E2E tests to continue working after the infra changes merge
• No impact on other OpenShift CI workflows

Related PRs:

• hyperfleet-infra#57 - Infrastructure changes requiring E2E_RUN_ID

• HYPERFLEET-1108

Summary by CodeRabbit

Updates the HyperFleet OpenShift CI E2E setup so the installation step now passes E2E_RUN_ID as the current namespace name when running make install-hyperfleet.

Practically, this ensures HyperFleet E2E resources in the shared e2e-gcp flow are labeled with a unique run ID, improving tracking and cleanup and reducing conflicts between concurrent CI jobs. This change prepares the CI setup for the related hyperfleet-infra requirement without affecting other OpenShift CI workflows.

[openshift-merge-bot]

@mliptak0, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't checkout base SHA e4f6d6ec5e62e0edb87aba4fdda7412af69fb3d8: error checking out "e4f6d6ec5e62e0edb87aba4fdda7412af69fb3d8": exit status 128 fatal: unable to read tree (e4f6d6ec5e62e0edb87aba4fdda7412af69fb3d8)

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

Hi @mliptak0. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a5f0d793-638d-48fc-9584-d9f365a8ae98

📥 Commits

Reviewing files that changed from the base of the PR and between b69fe86 and 9cc489b.

📒 Files selected for processing (1)

• ci-operator/step-registry/openshift-hyperfleet/e2e/setup/openshift-hyperfleet-e2e-setup-commands.sh

---

Walkthrough

The make install-hyperfleet invocation in the hyperfleet E2E setup script is updated to pass E2E_RUN_ID (set to the value of NAMESPACE_NAME) as an additional environment variable, alongside the pre-existing NAMESPACE and HELMFILE_ENV assignments.

Changes

Hyperfleet E2E Setup Environment Variable

Layer / File(s)	Summary
Pass E2E_RUN_ID to make install-hyperfleet ci-operator/step-registry/openshift-hyperfleet/e2e/setup/openshift-hyperfleet-e2e-setup-commands.sh	E2E_RUN_ID=$NAMESPACE_NAME is added to the make install-hyperfleet environment alongside the existing NAMESPACE and HELMFILE_ENV variables.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• openshift/release#80366: Directly modifies the same make install-hyperfleet invocation in openshift-hyperfleet-e2e-setup-commands.sh to change the install mechanism, making it the closest functional neighbor to this change.

Suggested reviewers

• tirthct
• rh-amarin

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: passing E2E_RUN_ID during HyperFleet installation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR only updates a CI shell script and introduces no Ginkgo test titles or dynamic names.
Test Structure And Quality	✅ Passed	PR only changes a shell setup script; no Ginkgo test code or test structure was modified, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only updates a shell setup step to pass E2E_RUN_ID in make install-hyperfleet.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Only a setup shell script changed to pass E2E_RUN_ID; no Ginkgo It/Describe/Context/When tests were added or modified, so SNO test compatibility is not implicated.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only adds E2E_RUN_ID to a make install-hyperfleet invocation; it introduces no affinity, nodeSelector, spread, replica, or topology-aware scheduling changes.
Ote Binary Stdout Contract	✅ Passed	PASS: The PR only changes a Bash CI setup script to pass E2E_RUN_ID; it doesn’t touch OTE binary process-level code or introduce stdout logging.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a CI setup shell script changed; no new Ginkgo It/Describe/Context/When tests were added, so the IPv6/disconnected-network test check is not applicable.
No-Weak-Crypto	✅ Passed	The PR only adds E2E_RUN_ID to a shell install command; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret-comparison logic is present.
Container-Privileges	✅ Passed	Only a shell-step env var was added; no privileged/root/host* or allowPrivilegeEscalation settings appear in the HyperFleet workflow/ref manifests.
No-Sensitive-Data-In-Logs	✅ Passed	PASS: The change only passes E2E_RUN_ID into make; it adds no new logging or secret/PII output.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mliptak0
Once this PR has been reviewed and has the lgtm label, please assign kuudori for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/openshift-hyperfleet/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment