Feature/all client - #3853
Draft
delcroip wants to merge 11 commits into
Draft
Feature/all client#3853delcroip wants to merge 11 commits into
delcroip wants to merge 11 commits into
Conversation
Evaluate text/cql-identifier (and text/cql) initialExpression values from linked cqf-library extensions when opening a new questionnaire, and cover the flow with a unit test.
+ more Timber message
Author
|
@roywanyaga this is my current app OpenSRP POC server (Exoscale) — Traefik + LE IP certHost: 194.182.171.88FHIR: https://194.182.171.88/fhir/Keycloak: https://194.182.171.88/realms/opensrp/GlitchTip: https://194.182.171.88/logs/Web: https://194.182.171.88/web/App : demo / demo (client: fhir-core-client)GlitchTip UI: admin@opensrp.local / adminadminWeb : webadmin / webadminKeycloak : admin / admin |
Collaborator
|
Thanks @delcroip Let me review and give feedback by Tuesday next week. Thanks again for sharing this PR. |
Collaborator
|
It would be great to share some screenshots, but I will attempt to run the app and reach out in case I have any questions. @delcroip |
Collaborator
|
@delcroip can you share a pre-recorded video of the register in action to help with the review? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
features:
Fixes [link to issue]
Engineer Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guideCode Reviewer Checklist
strings.xmlfile