Repository navigation
[shiftstack] Bound soft-transient oc exec retries during pod polling - #4192
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Hi @tusharjadhav3302. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
84b7935 to
7139f5d
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 56s |
|
recheck |
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 07s |
|
/agentic_review |
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR |
7139f5d to
1fb42bd
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 18m 25s |
|
recheck |
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 49m 18s |
michburk
left a comment
michburk
left a comment
There was a problem hiding this comment.
One concern, otherwise looks much cleaner. Thanks!
1fb42bd to
a2bc174
Compare
a2bc174 to
92c0704
Compare
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 30s |
8fba0ac to
47ed24d
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 39m 10s |
|
recheck |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 5m 13s |
|
recheck |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 5m 18s |
|
recheck |
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 22m 50s |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brjackma The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 14m 04s |
|
/override rdoproject.org/github-check |
|
@Valkyrie00: Overrode contexts on behalf of Valkyrie00: rdoproject.org/github-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Ride through brief API VIP blips (connection refused / i/o timeout) with a consecutive failure budget instead of failing on the first poll or spinning for the full 8h window when the API is truly unreachable. Hard-transient patterns from openstack-k8s-operators#4150 keep the full poll timeout. Move the poller into roles/shiftstack/files/shiftstack_cmd_poll.sh and invoke it with ansible.builtin.script so it is copied from the controller. Match kubectl's "connection ... was refused" via connection.*refused. Signed-off-by: tusharjadhav3302 <tjadhav@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
47ed24d to
b89fdb3
Compare
|
New changes are detected. LGTM label has been removed. |
32250c1
into
openstack-k8s-operators:main
4 participants
Summary
oc execerrors (connection refused,i/o timeout) while polling long-running shiftstack tests inshiftstackclient.cifmw-dnsmasqrestarted mid-test) without spinning for ~8h when the API is truly unreachable.Why
On
shiftstack-rhel9-rhoso18.0-ocp4.23(serval70, 2026-09-17) the outer poller failed immediately on:The background
osp_verification_4.23_nightlyrun continued and completed afterward. Re-addingconnection refusedto the unlimited hard-transient list was deliberately rejected in #4150 review; this change uses a bounded soft budget instead (default 12 × 5s ≈ 60s).Test plan
connection refusedduring polling no longer fails the testconfigMade with Cursor