Repository navigation
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
A corrupted record in any single host's PCP archive caused pmrep to exit non-zero, which failed the "Collect the metrics from host" task and, since the gather play runs across all hosts at once, aborted the whole pcp-metrics hook even when every other host collected cleanly. pmrep still writes the valid rows to stdout before aborting on a corrupted record, so treat that specific failure as non-fatal: keep the partial output, emit a warning naming the affected host, and only skip the save when there is no output at all. Other non-zero exits (missing pmrep, bad metricspec, etc.) still fail the task as before. Signed-off-by: Luca Miccini <lmiccini@redhat.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
7f69c96 to
b544201
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 53m 07s Warning: |
A corrupted record in any single host's PCP archive caused pmrep to exit non-zero, which failed the "Collect the metrics from host" task and, since the gather play runs across all hosts at once, aborted the whole pcp-metrics hook even when every other host collected cleanly.
pmrep still writes the valid rows to stdout before aborting on a corrupted record, so treat that specific failure as non-fatal: keep the partial output, emit a warning naming the affected host, and only skip the save when there is no output at all. Other non-zero exits (missing pmrep, bad metricspec, etc.) still fail the task as before.