Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slagle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 15m 28s Warning: |
| vars: &heat_cifmw_test_operator_vars | ||
| change_item: "{{ zuul['items'] | selectattr('project.canonical_name', 'equalto', external_plugin) }}" | ||
| cifmw_extras: | ||
| s2i_extras: |
There was a problem hiding this comment.
Renaming cifmw_extras to s2i_extras inside the &heat_cifmw_test_operator_vars anchored block breaks heat-operator-tempest-multinode, which inherits the vars and heat is not enabled.
There was a problem hiding this comment.
Also, I'm still wondering why we need both the old and s2i job as I see that both are testing the same thing. The only difference I can see is s2i job builds the heat service images from s2i-openstack-containers main whereas the old job uses the already quay pushed image with the same source commit hash. Only difference is s2i job uses centos10 nodeset + 2 computes for the job.
There was a problem hiding this comment.
By the old job, I assume you mean heat-operator-tempest-multinode? Yea, I guess there is very little difference here. I'll check with the s2i working group and see what the long term plan here is.
|
Zuul encountered a syntax error while parsing its while scanning a simple key |
s2i_extras was added in openstack-k8s-operators/s2i-openstack-containers#200 and we can make use of it. Jira: OSPRH-37786 Signed-off-by: James Slagle <jslagle@redhat.com>
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 44s Warning: |
|
recheck looks like resource usage issue |
|
/hold consolidating the jobs here: |
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 06m 08s Warning: |
s2i_extras was added in
openstack-k8s-operators/s2i-openstack-containers#200
and we can make use of it.
Jira: OSPRH-37786
Signed-off-by: James Slagle jslagle@redhat.com