Skip to content

Add support for graphical consoles - #640

Open
steveb wants to merge 3 commits into
openstack-k8s-operators:mainfrom
steveb:graphical-console
Open

steveb wants to merge 3 commits into
openstack-k8s-operators:mainfrom
steveb:graphical-console

Conversation

@steveb

@steveb steveb commented Oct 30, 2025 •

Copy link
Copy Markdown
Collaborator

When the ironic spec graphicalConsoles is set to "Enabled" the following occurs:

  • a novncproxy container is added to the conductor pod
  • a route is added for users to access novncproxy URLs
  • conductor config is modified to enable graphical console drivers
  • [vnc] config enables the kubernetes container_provider[1]

Depends-On: openstack-k8s-operators/openstack-operator#1633
Jira: OSPRH-20211
[1] https://review.opendev.org/c/openstack/ironic/+/962242

Describe your changes

Jira Ticket Link

Jira:

Checklist before requesting a review

  • I have performed a self-review of my code and confirmed it passes tests
  • Performed pre-commit run --all
  • Tested operator image in a test/dev environment. It can be CRC via install_yamls or a hotstack instance (optional)
  • Verified that no failures present in logs(optional):
    • ironic-operator-build-deploy-kuttl
    • podified-multinode-ironic-deployment

@openshift-ci
openshift-ci Bot requested review from olliewalsh and stuggi October 30, 2025 21:43
@openshift-ci

openshift-ci Bot commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3e6f4be009d34ecfbfd18d037f86dbf5

❌ openstack-k8s-operators-content-provider FAILURE in 9m 24s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@steveb
steveb force-pushed the graphical-console branch from 63004fb to 2f9267c Compare November 3, 2025 21:11
@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/df1715ed20f64daabd4f1d348b436699

❌ openstack-k8s-operators-content-provider FAILURE in 9m 17s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul

Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/ironic-operator for 640,806c2986555d269e8bdf3acafed2300aca5c0a4b

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bee9bf548f8b42089d281988ac283c47

❌ openstack-k8s-operators-content-provider FAILURE in 10m 51s
⚠️ podified-multinode-ironic-deployment SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@steveb
steveb marked this pull request as ready for review October 5, 2026 02:13
@openshift-ci
openshift-ci Bot requested review from juliakreger and mumesan October 5, 2026 02:13
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dd8d0191-dde5-4bd0-a779-783e25158eb3
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

steveb added 3 commits October 6, 2026 15:07
When the ironic spec graphicalConsoles is set to "Enabled" the following
occurs:

- a novncproxy container is added to the conductor pod
- a route is added for users to access novncproxy URLs
- conductor config is modified to enable graphical console drivers
- [vnc] config enables the kubernetes container_provider

Jira: OSPRH-20211
TODO mount in /etc/ironic/ironic-console-pod.yaml.template

Currently graphical console pods (and related secrets) are created in the
openstack namespace. This increases security risks in 2 ways:
- Ironic service account is given access to secrets in the openstack
  namespace
- Graphical console pods share network namespace with other ironic
  services

Putting graphical console pods improves isolation with the rest of the
control plane. A future enhancement could be to create a namespace per
tenant to improve isolation of graphical console pods between tenants.

Jira: OSPRH-20211
@centosinfra-prod-github-app

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change openstack-k8s-operators/openstack-operator#1633 is needed.

@openshift-ci

openshift-ci Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@steveb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional b74384e link true /test functional
ci/prow/precommit-check b74384e link true /test precommit-check
ci/prow/ironic-operator-build-deploy-kuttl b74384e link true /test ironic-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant