Repository navigation
Fix Keystone Memcached endpoints for TLS and IPv6 - #697
openshift-merge-bot[bot] merged 1 commit into
Conversation
The [keystone_authtoken] section emitted memcached_servers using the TLS-listener list unconditionally, which for a non-TLS Memcached uses the wrong list and drops the inet6: prefix required for IPv6 addresses. It also gated memcache_tls_enabled and the MTLS cert files on MemcachedAuthCert (MTLS presence) rather than on whether the Memcached server runs with TLS. Select the server list based on .MemcachedTLS (TLS listener list when TLS, inet-prefixed plain list otherwise) and gate memcache_tls_enabled on .MemcachedTLS, nesting the MTLS cert files inside as an optional extra. Wire the MemcachedTLS template parameter in manila_controller.go, which was not previously exposed. Add functional tests covering the non-TLS keystone_authtoken output and the MTLS-with-TLS case. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
|
Build failed (check pipeline). Post ✔️ manila-s2i-content-provider SUCCESS in 5h 59m 30s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ manila-s2i-content-provider SUCCESS in 15m 27s |
|
recheck |
|
Build succeeded (check pipeline). ✔️ manila-s2i-content-provider SUCCESS in 6h 14m 20s |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmiccini, stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b9cb7f3
into
openstack-k8s-operators:main
The [keystone_authtoken] section emitted memcached_servers using the TLS-listener list unconditionally, which for a non-TLS Memcached uses the wrong list and drops the inet6: prefix required for IPv6 addresses. It also gated memcache_tls_enabled and the MTLS cert files on MemcachedAuthCert (MTLS presence) rather than on whether the Memcached server runs with TLS.
Select the server list based on .MemcachedTLS (TLS listener list when TLS, inet-prefixed plain list otherwise) and gate memcache_tls_enabled on .MemcachedTLS, nesting the MTLS cert files inside as an optional extra. Wire the MemcachedTLS template parameter in manila_controller.go, which was not previously exposed.
Add functional tests covering the non-TLS keystone_authtoken output and the MTLS-with-TLS case.