Skip to content

Disable share status updates during ensure - #702

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:18-stablefrom
gouthampacha:18-stable
Oct 22, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:18-stablefrom
gouthampacha:18-stable

Conversation

@gouthampacha

@gouthampacha gouthampacha commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Set update_shares_status_on_ensure = False for RHOSO 18

This alternative behavior will not be supported in RHOSO 18.

Resolves: OSPRH-39247

@openshift-ci
openshift-ci Bot requested review from abays and dprince October 19, 2026 15:42
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Central YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1d8bb213-0765-4b48-8262-c67f9752c956

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@fmount

fmount commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

@gouthampacha I think we can close this one and just cherry-pick #701 on both 18-stable and 18.0-FR7 via bot

@silvacarloss

Copy link
Copy Markdown
Contributor

/lgtm thank you for proposing this change, Goutham

@gouthampacha

Copy link
Copy Markdown
Contributor Author

@gouthampacha I think we can close this one and just cherry-pick #701 on both 18-stable and 18.0-FR7 via bot

yes! let me do that, thanks @fmount

@fmount fmount reopened this Oct 22, 2026
@fmount

fmount commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

we found #701 wasn't a clean cherry-pick, restoring this one and sorry @gouthampacha for the noise!

@silvacarloss

Copy link
Copy Markdown
Contributor

/lgtm - thank you for working on this change, @gouthampacha and thanks for restoring it, @fmount

@silvacarloss

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouthampacha, silvacarloss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gouthampacha,silvacarloss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fmount

fmount commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Oct 22, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 97f4d51 into openstack-k8s-operators:18-stable Oct 22, 2026
8 checks passed
@fmount

fmount commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

/cherry-pick 18.0-fr7

@openshift-cherrypick-robot

Copy link
Copy Markdown

@fmount: new pull request created: #704

Details

In response to this:

/cherry-pick 18.0-fr7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants