Repository navigation
[PyOV] Convert integer and bool arrays to a bf16 model input by value #39183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Somay-kousis
wants to merge
4
commits into
openvinotoolkit:master
Choose a base branch
from
Somay-kousis:fix/bf16-input-from-int-array
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8416f48
[PyOV] Convert integer and bool arrays to a bf16 model input by value
Somay-kousis 30e7551
[PyOV] Leave the generated data_dispatcher.pyi stub unchanged
Somay-kousis 937d2ec
[PyOV] Keep raw bf16 bits for 2-byte arrays on both dispatch paths
Somay-kousis 8307de9
[PyOV] Test 2D and non-contiguous int arrays into a bf16 input
Somay-kousis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[random line] Please add a 2D / non-contiguous int case. The int tests only cover contiguous 1D data, and
share_inputs=Falsehas no to_c_style copy in front of the conversion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 8307de9:
test_infer_bf16_input_from_2d_int_array, int32/int64/uint8 arrays of shape (4, 3) that are C-contiguous, transposed (Fortran order) and strided (every other column), with bothshare_inputsvalues. All 18 cases pass; with master'sdata_dispatcher.pyall 18 fail.