Skip to content

Fix double encoding of device model labels in dashboard #651 #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BHARATH0153 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Fix double encoding of device model labels in dashboard #651 #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions openwisp_utils/admin_theme/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ def get_dashboard_context(request):
filters.append(label)
label = labels_i18n[qs_key]
else:
filters.append(label)
# HTML escape labels coming from values in the DB
# to avoid possible XSS attacks caused by
# malicious DB values set by users
Expand Down
9 changes: 9 additions & 0 deletions tests/test_project/tests/test_dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,3 +294,12 @@ def test_get_dashboard_context_html_escape(self):
context["dashboard_charts"][1]["query_params"]["labels"][0],
"<strong>Projects with operators</strong>",
)

def test_filter_not_double_encoded(self):
project = Project.objects.create(name="Dongwon T&I")
Operator.objects.create(project=project, first_name="test", last_name="test")
request = MockRequest(user=MockUser(is_superuser=True))
context = get_dashboard_context(request)
chart = context["dashboard_charts"][0]
self.assertIn("Dongwon T&I", chart["filters"])
self.assertIn("Dongwon T&I", chart["query_params"]["labels"])
Loading