Skip to content

fix(raven): prevent stale gateway public Service/Endpoints on failover and multi-replica #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WorrierKhushal wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(raven): prevent stale gateway public Service/Endpoints on failover and multi-replica #2762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7063431
fix(raven): fix GatewayPublicService update on failover or multiple r…
WorrierKhushal Aug 19, 2026
f8bf3a7
test: add coverage for AlreadyExists reconcile-as-update, Create erro…
WorrierKhushal Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions pkg/yurtmanager/controller/raven/gatewaypublicservice/gateway_public_service_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,8 +280,9 @@ func (r *ReconcileService) manageService(ctx context.Context, gateway *ravenv1be
for i := 0; i < len(addSvc); i++ {
if err := r.Create(ctx, addSvc[i]); err != nil {
if apierrs.IsAlreadyExists(err) {
klog.V(2).Info(Format("service %s/%s has already exist, ignore creating it", addSvc[i].GetNamespace(), addSvc[i].GetName()))
return nil
klog.V(2).Info(Format("service %s/%s has already exist, reconcile it as update", addSvc[i].GetNamespace(), addSvc[i].GetName()))
updateSvc = append(updateSvc, addSvc[i])
continue
}
return fmt.Errorf("failed create service for gateway %s type %s , error %s", gateway.GetName(), gatewayType, err.Error())
}
Expand Down Expand Up @@ -309,8 +310,9 @@ func (r *ReconcileService) manageEndpoints(ctx context.Context, gateway *ravenv1
for i := 0; i < len(addEps); i++ {
if err := r.Create(ctx, addEps[i]); err != nil {
if apierrs.IsAlreadyExists(err) {
klog.V(2).Info(Format("endpoints %s/%s has already exist, ignore creating it", addEps[i].GetNamespace(), addEps[i].GetName()))
return nil
klog.V(2).Info(Format("endpoints %s/%s has already exist, reconcile it as update", addEps[i].GetNamespace(), addEps[i].GetName()))
updateEps = append(updateEps, addEps[i])
continue
}
return fmt.Errorf("failed create endpoints for gateway %s type %s , error %s", gateway.GetName(), gatewayType, err.Error())
}
Expand Down Expand Up @@ -486,7 +488,7 @@ func acquiredSpecService(gateway *ravenv1beta1.Gateway, gatewayType string, prox
case ravenv1beta1.Proxy:
services = append(services, corev1.Service{
ObjectMeta: metav1.ObjectMeta{
Name: util.FormatName(fmt.Sprintf("%s-%s", util.GatewayProxyServiceNamePrefix, gateway.GetName())),
Name: util.FormatName(fmt.Sprintf("%s-%s-%s", util.GatewayProxyServiceNamePrefix, gateway.GetName(), aep.NodeName)),
Namespace: util.WorkingNamespace,
Labels: map[string]string{
raven.LabelCurrentGateway: gateway.GetName(),
Expand All @@ -513,7 +515,7 @@ func acquiredSpecService(gateway *ravenv1beta1.Gateway, gatewayType string, prox
case ravenv1beta1.Tunnel:
services = append(services, corev1.Service{
ObjectMeta: metav1.ObjectMeta{
Name: util.FormatName(fmt.Sprintf("%s-%s", util.GatewayTunnelServiceNamePrefix, gateway.GetName())),
Name: util.FormatName(fmt.Sprintf("%s-%s-%s", util.GatewayTunnelServiceNamePrefix, gateway.GetName(), aep.NodeName)),
Namespace: util.WorkingNamespace,
Labels: map[string]string{
raven.LabelCurrentGateway: gateway.GetName(),
Expand Down
Loading
Loading