fix: guard nil ConfigMap.Data before assignment in two controllers - #2773
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: guard nil ConfigMap.Data before assignment in two controllers#2773AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
Fixes openyurtio#2709, openyurtio#2707 - gateway_dns_controller: initialize cm.Data when nil before writing DNS records, preventing a panic on ConfigMaps with no data field - platform_admin_controller: initialize cm.Data when nil in the writeFramework CreateOrUpdate callback ConfigMap.Data is optional in the Kubernetes API, so existing ConfigMaps may have a nil Data map. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2709, #2707
DNS records, preventing a panic on ConfigMaps with no data field
writeFramework CreateOrUpdate callback
ConfigMap.Data is optional in the Kubernetes API, so existing
ConfigMaps may have a nil Data map.