fix: guard nil pointer on property not found and add missing return in GetPods - #2784
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: guard nil pointer on property not found and add missing return in GetPods#2784AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
…n GetPods device_controller: add continue after NotFoundErr branch to prevent dereferencing nil actualProperty which caused a panic in the DeviceProperties map write. Fixes openyurtio#2779. otaupdate: add missing return after WriteErr in GetPods handler. When EncodePods fails, the handler now returns instead of falling through to WriteJSONResponse with nil data, which would write an empty but valid JSON response instead of the intended error. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2779 and #2771
device_controller: add continue after NotFoundErr branch to prevent
dereferencing nil actualProperty which caused a panic in the
DeviceProperties map write.
otaupdate: add missing return after WriteErr in GetPods handler.
When EncodePods fails, the handler now returns instead of falling
through to WriteJSONResponse with nil data.