fix(storage): add ValidateDiskKey to validate disk key format - #2785
Open
AruneshDwivedi wants to merge 2 commits into
Open
fix(storage): add ValidateDiskKey to validate disk key format#2785AruneshDwivedi wants to merge 2 commits into
AruneshDwivedi wants to merge 2 commits into
Conversation
Add ValidateDiskKey to validate the internal format of disk storage keys (path structure, GVR format, namespace/name segments). Update disk storage Create/Delete/Get/List to use ValidateDiskKey instead of ValidateKey, catching malformed keys before file system operations instead of failing later with cryptic errors. Fixes openyurtio#2775 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
Add ValidateDiskKey function that validates the internal format of disk storage keys (component, GVR, namespace/name segments). Update disk storage Create/Delete/Get/List to call both ValidateKey (type check) and ValidateDiskKey (format check) before operations. This catches malformed keys early instead of failing later with cryptic errors during file system operations. Fixes openyurtio#2775 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
AruneshDwivedi
force-pushed
the
fix/validatekey-format-2775
branch
from
August 29, 2026 08:07
99d22a8 to
1a094a7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2775
Add ValidateDiskKey function that validates the internal format of
disk storage keys (component, GVR, namespace/name segments).
Update disk storage Create/Delete/Get/List to call both ValidateKey
(type check) and ValidateDiskKey (format check) before operations.
This catches malformed keys early instead of failing later with
cryptic errors during file system operations.