fix(yurttunnel): avoid reusing pooled bufio.Reader in getResponse - #2787
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix(yurttunnel): avoid reusing pooled bufio.Reader in getResponse#2787AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
The getResponse function reads HTTP response headers into a bufio.Reader and returns the parsed *http.Response whose Body still reads from the underlying reader. Using a pooled reader and returning it to the pool via defer before the response body is fully consumed causes a data race when another goroutine reuses the same pooled reader. Create a fresh bufio.Reader instead of using the pool to eliminate the race condition. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2774
The getResponse function reads HTTP response headers into a bufio.Reader
and returns the parsed *http.Response whose Body still reads from the
underlying reader. Using a pooled reader and returning it to the pool
via defer before the response body is fully consumed causes a data race
when another goroutine reuses the same pooled reader.
Create a fresh bufio.Reader instead of using the pool to eliminate the
race condition.