fix(autonomy): propagate retry errors instead of swallowing in updateNodeStatus - #2789
Open
AruneshDwivedi wants to merge 1 commit into
Open
Conversation
…NodeStatus When updateNodeStatus exhausts all retries without a successful node update, the function now returns the accumulated error instead of silently returning a stale node object. This ensures the proxy caller is informed of the failure rather than receiving potentially outdated node status. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2769
When updateNodeStatus exhausts all retries without a successful node
update, the function now returns the accumulated error instead of
silently returning a stale node object. This ensures the proxy caller
is informed of the failure rather than receiving potentially outdated
node status.