Feature/74147 bring sprint sharing safe to corporate plan#23072
Open
Feature/74147 bring sprint sharing safe to corporate plan#23072
Conversation
ulferts
commented
May 5, 2026
| disabled: only_fallback_allowed, | ||
| caption: sharing_option_caption(Project::RECEIVE_SHARED), | ||
| data: { "show-when-value-selected-target": "cause" } | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
While less elegant than using the loop, I found it easier to read compared to having the abstraction of the loop also manifest and complicate the called methods for determining whether the button is disabled and which caption to show.
ulferts
force-pushed
the
feature/74147-bring-sprint-sharing-safe-to-corporate-plan
branch
from
883af75 to
f5af898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/74147
What are you trying to accomplish?
Guards sprint sharing with a corporate token requirement. The structure of the banners is a bit unusual.
If the setting for the sprint sharing is set to "Don't share" a page wide banner is displayed. If it is set to something else, the form is displayed with an inline banner. In that case, all but the "Don't share" option are disabled. This allows users to escape from another setting they might find themselves in.
TODOs
release/17.4(avoid multiple projects sharing with all after copying a project #23091)Screenshots
Merge checklist