Add Health Report for external Wiki providers#23100
Open
NobodysNightmare wants to merge 4 commits intodevfrom
Open
Add Health Report for external Wiki providers#23100NobodysNightmare wants to merge 4 commits intodevfrom
NobodysNightmare wants to merge 4 commits intodevfrom
Conversation
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
NobodysNightmare
force-pushed
the
wikis-health-report
branch
3 times, most recently
from
42e949b to
671d8e7
Compare
Making sure that wiki providers show up correctly in the "Integration type" column.
NobodysNightmare
force-pushed
the
wikis-health-report
branch
from
671d8e7 to
237ee43
Compare
They are still pretty rudimentary and might break if we change the query call signatures (e.g. passing access tokens differently), but they should work and provide a start. TODO: Specs
NobodysNightmare
force-pushed
the
wikis-health-report
branch
2 times, most recently
from
4bffd84 to
0d825b0
Compare
Linking it from a side panel in the wiki provider edit view. Mostly used the layout that was already present in the storages UI.
The internal provider is intended to get a separate UI where only few things are configurable (e.g. enable/disable). It's not possible to create multiple internal providers and one internal provider will always exist, so the list view does not make sense for it.
NobodysNightmare
force-pushed
the
wikis-health-report
branch
from
0d825b0 to
56b9f7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces basic connection validations for the XWiki provider and makes them accessible through the UI.
It also hides the internal Wiki provider from the Wiki providers index page, since our designs don't expect the internal provider to be configurable through this view at all and this would now cause additional problems, if we showed a validation for the internal provider.
Ticket
https://community.openproject.org/wp/72978