Skip to content

[74722] Document pattern for rails rendered split views#23110

Open
HDinger wants to merge 1 commit intodevfrom
code-maintenance/74722-document-pattern-for-rails-rendered-split-views
Open

[74722] Document pattern for rails rendered split views#23110
HDinger wants to merge 1 commit intodevfrom
code-maintenance/74722-document-pattern-for-rails-rendered-split-views

Conversation

@HDinger
Copy link
Copy Markdown
Contributor

@HDinger HDinger commented May 7, 2026

Ticket

https://community.openproject.org/wp/74722

What are you trying to accomplish?

Document split_view and split_create rails rendering in the lookbook

@HDinger HDinger added this to the 17.5.x milestone May 7, 2026
@HDinger HDinger requested a review from a team May 7, 2026 13:11
end
```

`split_view_base_route` is required by `WorkPackages::WithSplitViewHelper` to construct links that keep the split panel open while navigating within the page. It should return the URL of the current page, preserving any query parameters.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no WithSplitViewHelper

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that is a typo. 🙈 It should be WorkPackages::SplitViewHelper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants