Skip to content

[#73831] Sprints column scroll bar overlaps content#23119

Open
myabc wants to merge 2 commits intobug/74753-backlog-sprints-columns-full-heightfrom
bug/73831-sprints-column-scroll-overlap
Open

[#73831] Sprints column scroll bar overlaps content#23119
myabc wants to merge 2 commits intobug/74753-backlog-sprints-columns-full-heightfrom
bug/73831-sprints-column-scroll-overlap

Conversation

@myabc
Copy link
Copy Markdown
Contributor

@myabc myabc commented May 7, 2026

Note

This PR is based on #23118. Please review/merge that PR first.

Ticket

https://community.openproject.org/wp/73831

What are you trying to accomplish?

Fix padding so that scrollbars do not overlap content.

Screenshots

Browser Before After
Firefox/Win Screenshot 2026-05-07 at 23 18 34 Screenshot 2026-05-07 at 23 20 29
Chrome/Win Screenshot 2026-05-07 at 23 18 09 Screenshot 2026-05-07 at 23 19 35

What approach did you choose and why?

Important

This PR also cherry-picks 9071b9b from #22936 (now merged into dev)

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

Removes `_master_backlog.sass` rules tied to UI primitives that were
deleted in #22740 but were not cleaned up alongside them:
`.op-backlogs-header` and its modifiers, `.op-backlogs-container`,
`.op-backlogs-lists`, and the `backlogsListsContainer` container queries
that targeted the old header layout.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Backlogs “Sprint planning” layout styling to prevent the sprints column scrollbar from overlapping content by tweaking page padding and simplifying/retargeting sprint planning container styles.

Changes:

  • Extends Backlogs backlog show page content to the right side (extended-content--right) to remove right padding constraints.
  • Refactors sprint header and sprint planning layout styles to focus on .op-sprint-* selectors.
  • Updates the side-by-side divider styling for sprint planning columns in container queries.

Comment thread frontend/src/assets/sass/backlogs/_master_backlog.sass Outdated
@myabc myabc force-pushed the bug/73831-sprints-column-scroll-overlap branch from efa3345 to 85adc61 Compare May 7, 2026 17:11
Comment on lines +36 to +42
// Additional overrides of overrrides to make scrolling and margins work well
// when the details (split) pane is shown.
// see frontend/src/global_styles/layout/_base.sass
#content:has(#content-bodyRight > *)
// we remove the 1rem padding on #content-body, but leave #content-header.
#content-body
padding-right: 0
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HDinger @bsatarnejad this is very brittle and I'm certain it will break in the future. Let's figure out if we can refactor this.

@myabc myabc requested a review from HDinger May 7, 2026 17:17
@myabc myabc force-pushed the bug/73831-sprints-column-scroll-overlap branch from 85adc61 to b203f07 Compare May 7, 2026 21:02

.controller-backlogs\/backlog.action-show
.controller-backlogs\/backlog.action-show,
.controller-backlogs\/backlog.action-details
Copy link
Copy Markdown
Contributor Author

@myabc myabc May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, we need to apply this to both action-details and action-show. Turbo-loaded pages do not set the correct page class.

(I do not understand why this wasn't a problem for #23118 however)

@myabc myabc marked this pull request as ready for review May 7, 2026 21:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

@myabc myabc added this to the 17.4.x milestone May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants