Skip to content

[#74779] Rename WorkPackageCardListComponent#23146

Merged
myabc merged 1 commit into
devfrom
implementation/74779-rename-work-package-card-list-component
May 11, 2026
Merged

[#74779] Rename WorkPackageCardListComponent#23146
myabc merged 1 commit into
devfrom
implementation/74779-rename-work-package-card-list-component

Conversation

@myabc
Copy link
Copy Markdown
Contributor

@myabc myabc commented May 8, 2026

Ticket

https://community.openproject.org/wp/74779

What are you trying to accomplish?

Renames WorkPackageCardBoxComponent to WorkPackageCardListComponent. Split out from #23074.

Screenshots

no visual changes

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc myabc requested a review from Copilot May 8, 2026 21:56
@myabc myabc force-pushed the implementation/74779-rename-work-package-card-list-component branch from 7b5d6a2 to dcce7f5 Compare May 8, 2026 21:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns naming across the codebase by renaming the formerly misnamed WorkPackageCardBoxComponent to WorkPackageCardListComponent, updating Backlogs usage, styles, specs, Lookbook previews, and i18n keys accordingly.

Changes:

  • Renamed component constants/usages from WorkPackageCardBoxComponent to WorkPackageCardListComponent (including Backlogs-specific item component).
  • Updated CSS class names and Sass imports to match the new “card list” naming.
  • Moved the i18n namespace in en.yml and updated tests/page objects to reference the new key.

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
spec/components/open_project/common/work_package_card_list_component/item_spec.rb Updates spec to reference WorkPackageCardListComponent::Item and renamed test stub constants.
spec/components/open_project/common/work_package_card_list_component/header_spec.rb Updates spec to reference WorkPackageCardListComponent::Header.
spec/components/open_project/common/work_package_card_list_component/empty_item_spec.rb Updates spec to reference WorkPackageCardListComponent::EmptyItem.
spec/components/open_project/common/work_package_card_list_component_spec.rb Updates top-level component spec and renamed stubbed test component constants.
modules/backlogs/spec/support/pages/backlog.rb Updates i18n key used for accessible counter label; switches an expectation helper to have_text.
modules/backlogs/spec/components/backlogs/work_package_card_list_item_component_spec.rb Updates Backlogs item component spec to new class name.
modules/backlogs/spec/components/backlogs/bucket_component_spec.rb Updates i18n key used for the counter aria-label expectation.
modules/backlogs/app/components/backlogs/work_package_card_list_item_component.rb Renames Backlogs item component class to inherit from WorkPackageCardListComponent::Item.
modules/backlogs/app/components/backlogs/sprint_component.html.erb Renders WorkPackageCardListComponent and updates item_component_klass.
modules/backlogs/app/components/backlogs/inbox_component.html.erb Renders WorkPackageCardListComponent, updates item_component_klass, and renames “show more” row CSS class.
modules/backlogs/app/components/backlogs/bucket_component.html.erb Renders WorkPackageCardListComponent and updates item_component_klass.
lookbook/previews/open_project/common/work_package_card_list_component_preview.rb Renames Lookbook preview class and updates renders to the new component.
config/locales/en.yml Renames i18n namespace to work_package_card_list_component.
app/components/open_project/common/work_package_card_list_component/item.rb Renames the nested owner class to WorkPackageCardListComponent and updates comment wording.
app/components/open_project/common/work_package_card_list_component/header.sass Renames header CSS class to match “card list” naming.
app/components/open_project/common/work_package_card_list_component/header.rb Updates header nesting under WorkPackageCardListComponent.
app/components/open_project/common/work_package_card_list_component/header.html.erb Updates header markup to use the renamed CSS class.
app/components/open_project/common/work_package_card_list_component/empty_item.rb Updates nesting under WorkPackageCardListComponent.
app/components/open_project/common/work_package_card_list_component/content_item.rb Updates nesting under WorkPackageCardListComponent.
app/components/open_project/common/work_package_card_list_component.sass Renames the base “card box” CSS selector to “card list”.
app/components/open_project/common/work_package_card_list_component.rb Renames the main component class and adjusts related documentation wording.
app/components/open_project/common/work_package_card_list_component.html.erb Adds/updates the component template used to render the BorderBox list, header, items, and footer.
app/components/_index.sass Updates Sass imports to the new “card list” component paths.
Comments suppressed due to low confidence (1)

app/components/open_project/common/work_package_card_list_component.rb:147

  • The parameter documentation still refers to a “box” (e.g., “drives the box DOM id”) even though the class has been renamed to WorkPackageCardListComponent. Please update the remaining occurrences in this doc block to “list”/“card list” to keep the public API docs consistent.

Comment thread config/locales/en.yml
@myabc myabc marked this pull request as ready for review May 10, 2026 13:37
@github-actions
Copy link
Copy Markdown

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

@myabc myabc added feature needs review ruby Pull requests that update Ruby code labels May 10, 2026
@myabc myabc changed the title [#74684] Rename WorkPackageCardListComponent [#74684] Rename WorkPackageCardListComponent May 10, 2026
@myabc myabc added this to the 17.5.x milestone May 10, 2026
@myabc myabc changed the title [#74684] Rename WorkPackageCardListComponent [#74779] Rename WorkPackageCardListComponent May 10, 2026
@myabc myabc force-pushed the implementation/74779-rename-work-package-card-list-component branch from dcce7f5 to 7ef28be Compare May 10, 2026 17:20
@myabc myabc requested a review from EinLama May 10, 2026 17:21
Copy link
Copy Markdown
Contributor

@klaustopher klaustopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myabc myabc merged commit 7e79655 into dev May 11, 2026
16 of 17 checks passed
@myabc myabc deleted the implementation/74779-rename-work-package-card-list-component branch May 11, 2026 08:15
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

feature needs review ruby Pull requests that update Ruby code

Development

Successfully merging this pull request may close these issues.

3 participants