[#74779] Rename WorkPackageCardListComponent#23146
Merged
myabc merged 1 commit intoMay 11, 2026
Merged
Conversation
7b5d6a2 to
dcce7f5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns naming across the codebase by renaming the formerly misnamed WorkPackageCardBoxComponent to WorkPackageCardListComponent, updating Backlogs usage, styles, specs, Lookbook previews, and i18n keys accordingly.
Changes:
- Renamed component constants/usages from
WorkPackageCardBoxComponenttoWorkPackageCardListComponent(including Backlogs-specific item component). - Updated CSS class names and Sass imports to match the new “card list” naming.
- Moved the i18n namespace in
en.ymland updated tests/page objects to reference the new key.
Reviewed changes
Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/components/open_project/common/work_package_card_list_component/item_spec.rb | Updates spec to reference WorkPackageCardListComponent::Item and renamed test stub constants. |
| spec/components/open_project/common/work_package_card_list_component/header_spec.rb | Updates spec to reference WorkPackageCardListComponent::Header. |
| spec/components/open_project/common/work_package_card_list_component/empty_item_spec.rb | Updates spec to reference WorkPackageCardListComponent::EmptyItem. |
| spec/components/open_project/common/work_package_card_list_component_spec.rb | Updates top-level component spec and renamed stubbed test component constants. |
| modules/backlogs/spec/support/pages/backlog.rb | Updates i18n key used for accessible counter label; switches an expectation helper to have_text. |
| modules/backlogs/spec/components/backlogs/work_package_card_list_item_component_spec.rb | Updates Backlogs item component spec to new class name. |
| modules/backlogs/spec/components/backlogs/bucket_component_spec.rb | Updates i18n key used for the counter aria-label expectation. |
| modules/backlogs/app/components/backlogs/work_package_card_list_item_component.rb | Renames Backlogs item component class to inherit from WorkPackageCardListComponent::Item. |
| modules/backlogs/app/components/backlogs/sprint_component.html.erb | Renders WorkPackageCardListComponent and updates item_component_klass. |
| modules/backlogs/app/components/backlogs/inbox_component.html.erb | Renders WorkPackageCardListComponent, updates item_component_klass, and renames “show more” row CSS class. |
| modules/backlogs/app/components/backlogs/bucket_component.html.erb | Renders WorkPackageCardListComponent and updates item_component_klass. |
| lookbook/previews/open_project/common/work_package_card_list_component_preview.rb | Renames Lookbook preview class and updates renders to the new component. |
| config/locales/en.yml | Renames i18n namespace to work_package_card_list_component. |
| app/components/open_project/common/work_package_card_list_component/item.rb | Renames the nested owner class to WorkPackageCardListComponent and updates comment wording. |
| app/components/open_project/common/work_package_card_list_component/header.sass | Renames header CSS class to match “card list” naming. |
| app/components/open_project/common/work_package_card_list_component/header.rb | Updates header nesting under WorkPackageCardListComponent. |
| app/components/open_project/common/work_package_card_list_component/header.html.erb | Updates header markup to use the renamed CSS class. |
| app/components/open_project/common/work_package_card_list_component/empty_item.rb | Updates nesting under WorkPackageCardListComponent. |
| app/components/open_project/common/work_package_card_list_component/content_item.rb | Updates nesting under WorkPackageCardListComponent. |
| app/components/open_project/common/work_package_card_list_component.sass | Renames the base “card box” CSS selector to “card list”. |
| app/components/open_project/common/work_package_card_list_component.rb | Renames the main component class and adjusts related documentation wording. |
| app/components/open_project/common/work_package_card_list_component.html.erb | Adds/updates the component template used to render the BorderBox list, header, items, and footer. |
| app/components/_index.sass | Updates Sass imports to the new “card list” component paths. |
Comments suppressed due to low confidence (1)
app/components/open_project/common/work_package_card_list_component.rb:147
- The parameter documentation still refers to a “box” (e.g., “drives the box DOM id”) even though the class has been renamed to
WorkPackageCardListComponent. Please update the remaining occurrences in this doc block to “list”/“card list” to keep the public API docs consistent.
3 tasks
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
WorkPackageCardListComponent
WorkPackageCardListComponentWorkPackageCardListComponent
dcce7f5 to
7ef28be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/74779
What are you trying to accomplish?
Renames
WorkPackageCardBoxComponenttoWorkPackageCardListComponent. Split out from #23074.Screenshots
no visual changes
What approach did you choose and why?
Merge checklist