Skip to content

[FSSDK-12610] Fix: PHP 8.4 implicit nullable parameter deprecation warnings #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tamara-Barum merged 3 commits into from
May 20, 2026
Merged

[FSSDK-12610] Fix: PHP 8.4 implicit nullable parameter deprecation warnings #296

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4395dea
[FSSDK-12610] Fix: PHP 8.4 implicit nullable parameter deprecation wa…
Tamara-Barum May 20, 2026
c2b6fef
[FSSDK-12610] Fix remaining implicit nullable parameters in Validator…
Tamara-Barum May 20, 2026
a68bd24
[FSSDK-12610] Update PHPDoc to reflect explicit nullable parameter types
Tamara-Barum May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Optimizely/DecisionService/DecisionService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class DecisionService
* @param LoggerInterface $logger
* @param UserProfileServiceInterface $userProfileService
*/
public function __construct(LoggerInterface $logger, UserProfileServiceInterface $userProfileService = null)
public function __construct(LoggerInterface $logger, ?UserProfileServiceInterface $userProfileService = null)
Comment thread
Tamara-Barum marked this conversation as resolved.
{
$this->_logger = $logger;
$this->_bucketer = new Bucketer($logger);
Expand Down
12 changes: 6 additions & 6 deletions src/Optimizely/Optimizely.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,13 @@ class Optimizely
*/
public function __construct(
$datafile,
EventDispatcherInterface $eventDispatcher = null,
LoggerInterface $logger = null,
ErrorHandlerInterface $errorHandler = null,
?EventDispatcherInterface $eventDispatcher = null,
?LoggerInterface $logger = null,
?ErrorHandlerInterface $errorHandler = null,
Comment thread
Tamara-Barum marked this conversation as resolved.
$skipJsonValidation = false,
UserProfileServiceInterface $userProfileService = null,
ProjectConfigManagerInterface $configManager = null,
NotificationCenter $notificationCenter = null,
?UserProfileServiceInterface $userProfileService = null,
?ProjectConfigManagerInterface $configManager = null,
?NotificationCenter $notificationCenter = null,
Comment thread
Tamara-Barum marked this conversation as resolved.
$sdkKey = null,
array $defaultDecideOptions = []
) {
Comment thread
Tamara-Barum marked this conversation as resolved.
Expand Down
6 changes: 3 additions & 3 deletions src/Optimizely/ProjectConfigManager/HTTPProjectConfigManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ public function __construct(
$fetchOnInit = true,
$datafile = null,
$skipJsonValidation = false,
LoggerInterface $logger = null,
ErrorHandlerInterface $errorHandler = null,
NotificationCenter $notificationCenter = null,
?LoggerInterface $logger = null,
?ErrorHandlerInterface $errorHandler = null,
?NotificationCenter $notificationCenter = null,
$datafileAccessToken = null
) {
$this->_skipJsonValidation = $skipJsonValidation;
Expand Down
Loading