Skip to content

fix: remove app module and keeper - #151

Merged
GNaD13 merged 16 commits into
release/v0.50.xfrom
fix/soft-remove-evm
Aug 11, 2026
Merged

fix: remove app module and keeper#151
GNaD13 merged 16 commits into
release/v0.50.xfrom
fix/soft-remove-evm

Conversation

@GNaD13

@GNaD13 GNaD13 commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@GNaD13
GNaD13 marked this pull request as ready for review August 10, 2026 10:59
@trung2891

trung2891 commented Aug 10, 2026

Copy link
Copy Markdown
Member

⚠️ app/bank.go:79 — chặn recipient có thể halt chain ở EndBlocker

BlacklistSendRestriction reject cả toAddr, và SendRestrictionFn áp cho cả module→account transfer, không chỉ user→user.

Path halt:
gov.EndBlocker → RefundAndDeleteDeposits → SendCoinsFromModuleToAccount tới addr blacklist → restriction trả error → error thoát ra EndBlocker → chain halt.

Cùng class: staking reward withdrawal, IBC timeout refund, unbonding completion.

Burn ở ForkHeight không cover case này — deposit đang nằm ở module account gov, không phải balance của account bị blacklist.

Nhờ check on-chain 3 addr (orai1vyghw3r3567y2algruuflqw2hx05vt6k945wrq, orai1hru4a5w0c29wr36l2dgaymqqd4h0vju9tlvk8w, orai1ycryq0mghafwfwr346d5qe2ce8zvmflns08khy) xem có gov deposit / unbonding / redelegation đang treo không.

Fix an toàn: bỏ check toAddr, chỉ chặn fromAddr. Chặn chiều ra là đủ để đóng băng quỹ, và tránh mọi đường module→account.

trung2891
trung2891 approved these changes Aug 11, 2026
View reviewed changes

@trung2891 trung2891 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ducphamle2
ducphamle2 self-requested a review August 11, 2026 02:42
ducphamle2
ducphamle2 approved these changes Aug 11, 2026
View reviewed changes

@ducphamle2 ducphamle2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GNaD13
GNaD13 merged commit 0557640 into release/v0.50.x Aug 11, 2026
11 of 12 checks passed
@GNaD13
GNaD13 deleted the fix/soft-remove-evm branch August 11, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ducphamle2 ducphamle2 ducphamle2 approved these changes
@trung2891 trung2891 trung2891 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GNaD13 @trung2891 @ducphamle2