heal(verify): registry-declared gate deadlines — pytest gates outlive the 300s wave default - #1671
Conversation
… the 300s wave default PR #1666's parallel runner capped every gate at 300s; the 1,200-test pytest-cli suite cannot finish in five minutes, so every cli-touching PR became unmergeable (two merge groups + one PR head died on gate-command-timeout within the hour). A gate row may now declare timeout_seconds (GATES registry — one entry per fact); the row can only EXTEND the wave default, never shrink it. pytest-cli: 1500s, pytest-api: 900s. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHjMkFUZJ1pK21oyv1ropN
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Multi-agent review roll call (CodeRabbit and Claude review automatically. Reviewers: post substantive findings only. Authors/agents: address every thread, push fixes to this branch, reply and resolve, then re-request review.) |
|
Warning Review limit reached
Next review available in: 16 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
To use Codex here, create a Codex account and connect to github. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aeaedfcdcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| row_timeout = (gates[gate_id] or {}).get("timeout_seconds") | ||
| gate_deadline = max(timeout_seconds, float(row_timeout)) if row_timeout else timeout_seconds |
There was a problem hiding this comment.
Validate timeout_seconds in scripts/check-gates.py before consuming it here. The registry schema checker currently accepts this new field without checking its type or range, so a future value such as a string crashes the wave before producing a gate receipt, while YAML .inf creates an unbounded process deadline. That defeats the repository requirement that every gate have a finite deadline; require a positive finite number within an explicit ceiling.
AGENTS.md reference: AGENTS.md:L139-L143
Useful? React with 👍 / 👎.
1 participant
Regression heal for #1666's parallel runner: the flat 300s per-gate deadline kills
pytest-cli(1,200+ tests) mid-run — two merge groups and one PR head died ongate-command-timeoutwithin the hour (runs 30564023252, 30564647125, 30565567887), making every cli-touching PR unmergeable (first victim: #1670).verify.py: a gate row may declaretimeout_seconds; it can only EXTEND the wave default, never shrink it.gates.yaml:pytest-cli: 1500·pytest-api: 900— one registry entry per fact, per the gate-estate law.Gates: syntax ok · check-gates OK (79 gates) · verify-parallel scheduling fixtures pass.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VHjMkFUZJ1pK21oyv1ropN