heal(tests): host-admission tests track cmd_changed's wave signature (#1666 masked breakage) - #1673
Conversation
PR #1666 changed cmd_changed to require jobs/gate_timeout_seconds/ gate_output_bytes and moved run_gate into keyword-arg wave execution, but its diff never touched cli/** — pytest-cli was not implicated, so main landed with three broken tests, masked by scoping until the first cli-touching PR ran the suite (#1670: 3 failed, 4479 passed). Calls updated; run_gate mocks absorb kwargs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHjMkFUZJ1pK21oyv1ropN
|
Multi-agent review roll call (CodeRabbit and Claude review automatically. Reviewers: post substantive findings only. Authors/agents: address every thread, push fixes to this branch, reply and resolve, then re-request review.) |
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
To use Codex here, create a Codex account and connect to github. |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
1 participant
Second regression heal from #1666: its
cmd_changedsignature change + kwarg waverun_gatenever updatedcli/tests/test_verify_host_admission.py, and since its diff didn't touchcli/**, pytest-cli was never implicated — main landed with 3 broken tests, invisible until the first cli-touching PR ran the full suite (#1670's gate:3 failed, 4479 passed).Local: the 5 host-admission tests pass. This is the masked-failure class the charter names — the scoped-gate design trade surfaced exactly as documented.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VHjMkFUZJ1pK21oyv1ropN