conditions: add not_arch - #2621
Merged
Merged
Conversation
Support a `not_arch` condition similar to `not_distro`, this is useful for this [1] PR to exclude firmware packages only on `s390x`. [1]: osbuild#2620 Signed-off-by: Simon de Vlieger <cmdr@supakeen.com>
avitova
reviewed
Aug 26, 2026
avitova
left a comment
avitova
left a comment
Contributor
There was a problem hiding this comment.
Although I do not like the Eval function, this addition looks good.
Why are we using the match = match && ..., when we can just return false as soon as match == false?
avitova
approved these changes
Aug 26, 2026
Member
Author
Good question since they're documented as AND, consistency for now though. |
achilleas-k
approved these changes
Aug 26, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 26, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support a
not_archcondition similar tonot_distro, this is useful for this 1 PR to exclude firmware packages only ons390x.