check: use mariadb-client instead of mysql-client#2890
Merged
Conversation
On Ubuntu, mysql-client resolves to the MySQL 8.0 client, which sends utf8mb4_0900_ai_ci during SQL queries. MariaDB rejects that collation with ERROR 1273 (HY000) until 11.4.5; kolla 2024.2 ships MariaDB 10.11. The nagios plugin then reports CRITICAL even when the Galera cluster is healthy. mariadb-client provides a mysql compatibility symlink, so check_executable mysql in the nagios plugin continues to work. The package is available in Ubuntu universe on 20.04, 22.04, and 24.04. The Ubuntu/Debian split was introduced in 30b9f52 to add Debian support; Debian already used mariadb-client. Ubuntu should too since the target server is always MariaDB. AI-assisted: Claude Code Signed-off-by: Roger Luethi <luethi@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mysql-clientresolves to the MySQL 8.0 client, which sendsutf8mb4_0900_ai_ciin SQL query packets. MariaDB rejects that collation withERROR 1273 (HY000)on versions before 11.4.5; kolla 2024.2 ships MariaDB 10.11.check_galera_clusternagios plugin's first real SQL query fails silently, leavingwsrep_cluster_state_uuidempty and causing the plugin to reportCRITICAL: node is not part of a clustereven when the cluster is healthy.mysql-client/mariadb-client) withmariadb-clientunconditionally.mariadb-clientprovides amysqlcompatibility symlink, so thecheck_executable mysqlcheck in the plugin continues to work. The package is available in Ubuntu universe on 20.04, 22.04, and 24.04.Test plan
--version-manager 9.5.0(soMANAGER_VERSION=9.5.0in/opt/manager-vars.sh, which triggers thecheck_galera_clusterpath in200-infrastructure.shrather thanosism status database)check.shrancheck_galera_clusterwithmariadb-clientinstalled — returnedOK: number of NODES = 3with no collation error🤖 Generated with Claude Code