Skip to content

k3s: guard version test against non-semver manager_version #2892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jklare merged 1 commit into from
May 20, 2026
Merged

k3s: guard version test against non-semver manager_version #2892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions inventory/group_vars/testbed-nodes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,14 @@ cilium_bgp_neighbors:
# kubevip -> frr
# osism-ansible < 9.0.0 uses bgppeers (old format); osism-kubernetes >= 9.0.0 uses bgp_peers.
# Only pass the list for 9.0.0+; 8.x falls back to kube_vip_bgp_peeraddress/kube_vip_bgp_peeras.
# The match('^[0-9]') guard is required because in 9.x the inventory reconciler sets
# manager_version to a date-based container tag (e.g. v0.20251130.0) rather than the OSISM
# release semver; LooseVersion cannot compare 'v...' against a numeric version and raises a
# TypeError. Non-semver values always indicate a 9.x+ deployment, so they take the else branch.
kube_vip_bgp_peers: >-
{{ [] if (manager_version is defined
and manager_version != 'latest'
and manager_version is match('^[0-9]')
and manager_version is version('9.0.0', '<'))
else [{'peer_address': '192.168.128.5', 'peer_asn': 64512}] }}

Expand Down