Skip to content

Let pybind11 modules release the GIL when used with free-threaded Python #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Let pybind11 modules release the GIL when used with free-threaded Python #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["scikit-build-core", "pybind11>=2.13"]
requires = ["scikit-build-core", "pybind11>=3.0.0"]
build-backend = "scikit_build_core.build"

[project]
Expand All @@ -20,9 +20,12 @@ authors = [
dependencies = [
"jinja2",
"numpy>=1.7",
"numpy>=2.1.0; python_version >= '3.14'",
"scipy>=0.13.2",
"scipy>=1.15.2; python_version >= '3.14'",
"setuptools",
"joblib",
"joblib>=1.4.2; python_version >= '3.14'",
]

[project.urls]
Expand Down
2 changes: 1 addition & 1 deletion src/bindings.cpp.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ OSQPInt PyOSQPSolver::codegen(const char *output_dir, const char *file_prefix, O
return osqp_codegen(this->_solver, output_dir, file_prefix, &defines);
}

PYBIND11_MODULE(@OSQP_EXT_MODULE_NAME@, m) {
PYBIND11_MODULE(@OSQP_EXT_MODULE_NAME@, m, py::mod_gil_not_used()) {

#ifdef OSQP_USE_FLOAT
m.attr("OSQP_USE_FLOAT") = 1;
Expand Down
2 changes: 1 addition & 1 deletion src/osqp/codegen/pywrapper/bindings.cpp.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ OSQPInt update_data_mat(py::object P_x, py::object P_i, py::object A_x, py::obje
}
#endif

PYBIND11_MODULE({{extension_name}}, m) {
PYBIND11_MODULE({{extension_name}}, m, py::mod_gil_not_used()) {
m.def("solve", &solve);
m.def("update_data_vec", &update_data_vec, "Update q/l/u", py::arg("q") = py::none(), py::arg("l") = py::none(), py::arg("u") = py::none());
#if OSQP_EMBEDDED_MODE == 2
Expand Down