fix: warm latent cache loading does an unnecessary model swap#840
Open
Mandrakia wants to merge 1 commit into
Open
fix: warm latent cache loading does an unnecessary model swap#840Mandrakia wants to merge 1 commit into
Mandrakia wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LatentCachingMixinwraps unconditionally the caching loop withOn a warm start where every latent is already cached, the loop body is just
os.path.existschecks — nothing is encoded — yet the device-state preset still moves models (notably the 9B transformer) off the GPU and back on, once per dataset × resolution pass. That move, not the encoding, is what makes warm starts take 10s+.Fix
Change device state only the first time we actually hit a cache miss (gated behind a
did_moveflag), and restore only if we moved. This mirrors the patterncache_text_embeddingsalready uses forcache_text_encoder.Cold starts are unchanged; warm starts skip the unnecessary GPU shuffle.