Fixed macstats loading on Mac OS in the UI#851
Open
kinnrai wants to merge 1 commit into
Open
Conversation
kinnrai
force-pushed
the
fix/macstats-loading-on-mac
branch
from
9d86267 to
adb08ca
Compare
|
I tried this and it seems to work. Will it be merged? |
|
It would be great when it will be merged. By the way what macstats do you install? I installed the jkuri repository but after seeing no results I left it there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue on Mac OS where the
macstatsmodule could fail to load, causing the GPU monitor panel to show all zero values.The issue was caused by loading
macstatsthroughcreateRequire()in the Next.js server routes. During the Next.js build, this created a broken runtime module resolution path for the ESM module, so the built route could still throwCannot find module 'macstats'even whenmacstatswas installed correctly.This changes the Mac CPU and GPU API routes to load
macstatsthrough a shared dynamic import helper instead.Closes #790.