Skip to content

🍻 draft: try vault action #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jobs62 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

🍻 draft: try vault action #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 31 additions & 18 deletions .github/workflows/code-check-identified.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,40 @@

permissions:
contents: read
id-token: write

jobs:
code-check:
runs-on: ubuntu-24.04
runs-on: [self-hosted, vault]
environment: eu-west-2
if: "! contains(github.event.pull_request.labels.*.name, 'dependencies')"
steps:
- name: 🧹 Frieza
uses: outscale/frieza-github-actions/frieza-clean@master
with:
access_key: ${{ secrets.OSC_ACCESS_KEY }}
secret_key: ${{ secrets.OSC_SECRET_KEY }}
region: ${{ secrets.OSC_REGION }}
- name: ⬇️ Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
- name: Setup toolchain
uses: ./.github/actions/setup-test
- name: 🧪 Run integration tests
env:
OSC_ACCESS_KEY: ${{ secrets.OSC_ACCESS_KEY }}
OSC_SECRET_KEY: ${{ secrets.OSC_SECRET_KEY }}
OSC_TEST_LOGIN: ${{ secrets.OSC_TEST_LOGIN }}
OSC_TEST_PASSWORD: ${{ secrets.OSC_TEST_PASSWORD }}
run: make test-int
- name: Import Secrets
id: import-secrets
uses: hashicorp/vault-action@v2

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Code check On outscale' step
Uses Step: import-secrets
Loading
uses 'hashicorp/vault-action' with ref 'v2', not a pinned commit hash
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
url: http://127.0.0.1:8200/
method: jwt
path: github-action
role: gha-osc-sdk-python
secrets: |
eu-west-2/creds/sdk access_key | OSC_ACCESS_KEY ;
eu-west-2/creds/sdk secret_key | OSC_SECRET_KEY

- name: 🧹 Frieza
uses: outscale/frieza-github-actions/frieza-clean@master

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Code check On outscale' step
Uses Step
Loading
uses 'outscale/frieza-github-actions/frieza-clean' with ref 'master', not a pinned commit hash
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
access_key: ${{ steps.import-secrets.outputs.OSC_ACCESS_KEY }}
secret_key: ${{ steps.import-secrets.outputs.OSC_SECRET_KEY }}
region: ${{ secrets.OSC_REGION }}
- name: ⬇️ Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
- name: Setup toolchain
uses: ./.github/actions/setup-test
- name: 🧪 Run integration tests
env:
OSC_ACCESS_KEY: ${{ steps.import-secrets.outputs.OSC_ACCESS_KEY }}
OSC_SECRET_KEY: ${{ steps.import-secrets.outputs.OSC_SECRET_KEY }}
OSC_TEST_LOGIN: ${{ secrets.OSC_TEST_LOGIN }}
OSC_TEST_PASSWORD: ${{ secrets.OSC_TEST_PASSWORD }}
run: make test-int
Loading