Skip to content

[JSC] Hold the value and the key of a super property store in a RefPtr across ensureThis() - #1016

Open
robobun wants to merge 1 commit into
mainfrom
robobun/e0501bca/super-property-store-registers
Open

robobun wants to merge 1 commit into
mainfrom
robobun/e0501bca/super-property-store-registers

[JSC] An assignment to a super property keeps its value in a register…

6ce25b1
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Nov 9, 2026 in 11m 42s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 1
Severity File:Line Issue
🟣 Pre-existing Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:4313 Script that assigns to a super bracket property before super() has run sees the right-hand side's side effects before th