Skip to content

JSObject::getPropertySlot: reload the structure before the prototype step #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JSObject::getPropertySlot: reload the structure before the prototype step #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Source/JavaScriptCore/runtime/JSObject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,6 +1281,10 @@ ALWAYS_INLINE bool JSObject::getPropertySlot(JSGlobalObject* globalObject, Prope
}
// FIXME: This doesn't look like it's following the specification:
// https://bugs.webkit.org/show_bug.cgi?id=172572
// Reload the structure: reifying a static lazy property above can transition
// the object and still miss (its PropertyCallback builder threw), like the
// megamorphic slow paths in JITOperations.cpp do.
structure = object->structureID().decode();
JSValue prototype = structure->storedPrototype(object);
if (!prototype.isObject())
break;
Expand Down
Loading